Skip to content

Conversation

@rosean3
Copy link
Contributor

@rosean3 rosean3 commented Apr 5, 2024

Description

reference the notion task

Type of change

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ”₯ Hot Fix
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • ⚑️ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • ⏩ Revert
  • πŸ“¦ Chore (Release)
  • πŸ” CI
  • πŸ“ Documentation Update

Required About this PR?

  • Non-breaking change
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚠️ This change requires a documentation update

Checklist:

`

  • My code follows the style guidelines of this project`
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

How Has This Been Tested?

  • pass in an array of an array of permissions (something like this: [['permission1'], ['permission2.1', 'permission2.2']]) and check that:
    1. the permissions of the user are only within those listed in the array.
    2. the authorizations is validated according to the specified permissions (obs.: note that the array is an OR of ANDs)

@notion-workspace
Copy link

@rosean3 rosean3 requested a review from nmf2 April 5, 2024 14:21
@rosean3 rosean3 marked this pull request as draft April 16, 2024 14:10
@rosean3 rosean3 changed the title [TASK-1030] feat: pass flattened permissions as specific permissions to getUserData [TASK-1181] feat: pass flattened permissions as specific permissions to getUserData Apr 16, 2024
@notion-workspace
Copy link

Task Nova

@rosean3 rosean3 self-assigned this Apr 19, 2024
@rosean3 rosean3 marked this pull request as ready for review April 26, 2024 20:36
@nmf2 nmf2 force-pushed the feature/get-specific-permissions-only branch from 5696516 to 16e879d Compare July 3, 2024 20:33
@nmf2 nmf2 force-pushed the feature/get-specific-permissions-only branch from 16e879d to 2b55bbe Compare July 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants