- 
                Notifications
    
You must be signed in to change notification settings  - Fork 223
 
          WIP: Add support for mbind, get_mempolicy and set_mempolicy
          #938
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ealliance#938) This adds support for the `mbind`, `set_mempolicy` and `get_mempolicy` NUMA syscalls. The `get_mempolicy` syscall has a few different modes of operation, depending on the flags, which is demultiplexed into `get_mempolicy_node` and `get_mempolicy_next_node` for now. There's a couple of other modes that writes into the variable length bit array, which aren't implemented for now.
6fe1aa4    to
    f321b15      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a first glance, this change looks reasonable!
        
          
                tests/numa/mbind.rs~
              
                Outdated
          
        
      | rustix::fs::seek(&alt, rustix::fs::SeekFrom::Current(0)), | ||
| Ok(12) | ||
| ); | ||
| } | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are mbind.rs~ and main.rs~ editor backups?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, oops, that's emacs backup files.
097eae4    to
    49a7171      
    Compare
  
    | 
           Pushed a new version: removed the emacs backup files, fixed   | 
    
| 
           This one: sunfishcode/linux-raw-sys#96  | 
    
52f2271    to
    4c5f6ce      
    Compare
  
    | 
           If you'd like this PR to be included in the rustix 0.38 series, please use linux-raw-sys 0.4.x. I've now released 0.4.12 with sunfishcode/linux-raw-sys#96. Another option is to open this PR in the 1.0-staging branch.  | 
    
          
 Oh, ok, thanks, I'll target 0.4.12 then.  | 
    
…ealliance#937) This adds support for the `mbind`, `set_mempolicy` and `get_mempolicy` NUMA syscalls. The `get_mempolicy` syscall has a few different modes of operation, depending on the flags, which is demultiplexed into `get_mempolicy_node` and `get_mempolicy_next_node` for now. There's a couple of other modes that writes into the variable length bit array, which aren't implemented for now.
| 
           Rustix 1.0.0 is now released, and it uses the latest linux-raw-sys, so it's no longer necessary to backport to linux-raw-sys 0.4.  | 
    
This adds support for the
mbind,set_mempolicyandget_mempolicyNUMA syscalls. Theget_mempolicysyscall has a few different modes of operation, depending on the flags, which is demultiplexed intoget_mempolicy_nodeandget_mempolicy_next_nodefor now. There's a couple of other modes that writes into the variable length bit array, which aren't implemented for now.