Bind the C API for components #308
Merged
+4,048
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a typo in the bindings generation script which set the `_fields` field rather than `_fields_`
|
Missing pieces:
I probably won't get to all of these before merging. |
|
I'm going to do follow-ups for more items here. |
alexcrichton
added a commit
to alexcrichton/wasmtime-py
that referenced
this pull request
Nov 5, 2025
This commit deletes two nice-to-have but difficult-to-maintain modules in this repository. Specifically: * The `wasmtime.loader` module is deleted as it was a proof-of-concept but doesn't map well to Python and Wasmtime. For example bytecodealliance#302 shows how destruction of Python modules isn't handled correctly. In general it's a "cute" implementation but isn't too too useful and doesn't map well to how Wasm is embedded in many contexts. I'm deleting this to reduce maintenance burden on this repository. It would be ok to reimplement in the future but it would likely require someone with more Python knowledge than I. * The `wasmtime.bindgen` module is deleted in favor of component support in bytecodealliance#308. This module still makes sense to have but it would need a ground-up rewrite to work with component types rather than component definitions. This is deferred to future work in bytecodealliance#309 and in the meantime it's removed to avoid any confusion about what should be used and what shouldn't. Closes bytecodealliance#105 Closes bytecodealliance#106 Closes bytecodealliance#107 Closes bytecodealliance#108 Closes bytecodealliance#109 Closes bytecodealliance#119 Closes bytecodealliance#143 Closes bytecodealliance#178 Closes bytecodealliance#181 Closes bytecodealliance#197 Closes bytecodealliance#202 Closes bytecodealliance#218 Closes bytecodealliance#245 Closes bytecodealliance#282 Closes bytecodealliance#302
alexcrichton
added a commit
that referenced
this pull request
Nov 5, 2025
* Delete `wasmtime.loader` and `wasmtime.bindgen` This commit deletes two nice-to-have but difficult-to-maintain modules in this repository. Specifically: * The `wasmtime.loader` module is deleted as it was a proof-of-concept but doesn't map well to Python and Wasmtime. For example #302 shows how destruction of Python modules isn't handled correctly. In general it's a "cute" implementation but isn't too too useful and doesn't map well to how Wasm is embedded in many contexts. I'm deleting this to reduce maintenance burden on this repository. It would be ok to reimplement in the future but it would likely require someone with more Python knowledge than I. * The `wasmtime.bindgen` module is deleted in favor of component support in #308. This module still makes sense to have but it would need a ground-up rewrite to work with component types rather than component definitions. This is deferred to future work in #309 and in the meantime it's removed to avoid any confusion about what should be used and what shouldn't. Closes #105 Closes #106 Closes #107 Closes #108 Closes #109 Closes #119 Closes #143 Closes #178 Closes #181 Closes #197 Closes #202 Closes #218 Closes #245 Closes #282 Closes #302 * Remove some more metadata * Remove build-rust build config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on bytecodealliance/wasmtime#11937