v1.3.1: Minor fixes for Firefox & Edge

[SYM01]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @SYM01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the proxy management system by introducing per-tab proxy detection and status display, particularly for auto-switch configurations. It refines the browser API abstraction layer to ensure broader compatibility and implements a robust mechanism for dynamically selecting proxy profiles based on URL patterns. These changes aim to provide users with more transparency and control over their proxy settings, alongside general maintenance and dependency updates.

Highlights

• Enhanced Auto-Switch Proxy Mode: Introduced a new AutoModeActionBar component and WebRequestStatsService to provide per-tab proxy detection and display, showing which proxy profile is active for the current tab and offering tips on detection limitations.
• Improved Browser API Abstraction: Refactored and expanded the BaseAdapter with new types and abstract methods for WebRequestResponseStartedDetails, MessageSender, Tab, getActiveTab, onTabRemoved, onMessage, and sendMessage. This improves compatibility and functionality across different browser environments (Chrome, Firefox, Edge).
• Dynamic Profile Resolution for Auto-Switch: The ProfileConverter now includes a findProfile method that dynamically resolves the appropriate proxy profile for a given URL in 'auto-switch' mode, utilizing new PAC script simulation functions (shExpMatch, isInNet).
• Dependency Updates and Build Improvements: Numerous dependencies, including Sentry, Vue, Acorn, Espree, and Vite, have been updated to their latest versions. A new build:test script was added, and Sentry/Visualizer plugins are now conditionally disabled for test builds.
• Internationalization and UI Adjustments: Added new internationalization keys for auto-switch mode (abbreviation, detection info, and tips) and made minor UI adjustments in the popup and config pages to accommodate the new features.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant new feature for "auto-switch" mode, allowing users to see which proxy profile is active for the current tab. It also includes numerous fixes and improvements, such as updating dependencies, improving Firefox compatibility, and fixing issues with storing reactive objects.

The implementation is well-structured, with new services for statistics collection (WebRequestStatsService) and PAC script simulation (pacSimulator). The adapter pattern is effectively used to handle browser differences, and the addition of comprehensive tests for the new logic is commendable.

I've found a few issues that need attention:

• A critical issue in the Firefox adapter's onWebRequestAuthRequired implementation that will likely break proxy authentication.
• A high-severity bug in PAC script generation that could lead to incorrect proxy settings.
• A medium-severity issue regarding the use of setTimeout as a workaround, which could be fragile.

Overall, this is a great set of changes that adds valuable functionality. Addressing the identified issues will make the implementation more robust and reliable.

[gemini-code-assist]

The implementation of onWebRequestAuthRequired for Firefox appears to be incorrect. The use of callback as any hides a type mismatch between the expected listener for browser.webRequest.onAuthRequired and the provided callback.

Firefox's onAuthRequired listener, when using asyncBlocking, expects a function that returns a Promise<BlockingResponse>. However, the provided callback (ProxyAuthProvider.onAuthRequired) is designed for Chrome's API and uses an asyncCallback argument instead of returning a promise. This will likely cause proxy authentication to fail on Firefox as the promise is never resolved.

To fix this, you should wrap the callback in a new function that returns a promise, and resolve it inside the asyncCallback.

  onWebRequestAuthRequired(
    callback: (
      details: WebAuthenticationChallengeDetails,
      asyncCallback?: (response: BlockingResponse) => void
    ) => BlockingResponse | undefined
  ): void {
    const listener = (
      details: WebAuthenticationChallenge-details
    ): Promise<BlockingResponse> => {
      return new Promise((resolve) => {
        // The callback can either return a response synchronously or call asyncCallback.
        const syncResponse = callback(details, (asyncResponse) => {
          resolve(asyncResponse);
        });

        // If it returned a response synchronously, resolve with it.
        if (syncResponse) {
          resolve(syncResponse);
        }
      });
    };

    browser.webRequest.onAuthRequired.addListener(
      listener,
      { urls: ["<all_urls>"] },
      ["asyncBlocking"]
    );
  }

[gemini-code-assist]

There's a subtle bug in this if condition. You are checking cfg.scheme == "http", but cfg.scheme can be undefined. You've correctly defined a scheme constant on line 43 to handle this case by defaulting to "http". You should use that scheme constant in this condition as well.

When cfg.scheme is undefined, scheme becomes "http", but cfg.scheme == "http" evaluates to false, causing the function to incorrectly generate an HTTPS proxy string instead of a PROXY string.

Suggested change

	if (["http", "https"].includes(scheme)) {
	return PACScriptHelper.newSimpleLiteral(
	`${cfg.scheme == "http" ? "PROXY" : "HTTPS"} ${host}`
	);
	}
	if (["http", "https"].includes(scheme)) {
	return PACScriptHelper.newSimpleLiteral(
	`${scheme == "http" ? "PROXY" : "HTTPS"} ${host}`
	);
	}

[gemini-code-assist]

Using setTimeout with an arbitrary delay to work around an issue is often a sign of a race condition and can be unreliable. The comment indicates this is a workaround for an indicator update issue in Chrome.

While this might work in most cases, it's fragile. It would be more robust to investigate the root cause of the update issue. Is there another browser event you could listen for that would guarantee the UI is ready for an update? For example, chrome.tabs.onUpdated with a status of complete might be a more reliable signal. Relying on a fixed delay can lead to inconsistent behavior on different machines or under heavy load.