Skip to content

add ImageSizeDetails to expansions#104

Merged
bzimmer merged 1 commit intomainfrom
imagesizedetails
Dec 25, 2025
Merged

add ImageSizeDetails to expansions#104
bzimmer merged 1 commit intomainfrom
imagesizedetails

Conversation

@bzimmer
Copy link
Owner

@bzimmer bzimmer commented Dec 25, 2025

  • improved debug and error logging

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (858e9e3) to head (fbf5f35).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   89.85%   90.22%   +0.36%     
==========================================
  Files          14       14              
  Lines        1272     1279       +7     
==========================================
+ Hits         1143     1154      +11     
+ Misses         78       76       -2     
+ Partials       51       49       -2     
Files with missing lines Coverage Δ
ls.go 94.49% <100.00%> (+4.29%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858e9e3...fbf5f35. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds ImageSizeDetails to the expansions used when retrieving images and albums, and enhances observability by adding structured debug and error logging throughout the ls command. The dependency on github.com/bzimmer/smugmug is updated from v0.8.2 to v0.8.3 to support these changes.

Key changes:

  • Added ImageSizeDetails expansion to image and album retrieval operations to fetch additional size metadata
  • Implemented structured logging using zerolog for all three resource types (image, album, node) with appropriate context fields
  • Added comprehensive test coverage for internal server error scenarios

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
ls.go Added ImageSizeDetails to expansions for image and album operations; added debug logging before API calls and error logging after failures for all three resource types
ls_test.go Added test cases and mock handlers to verify error handling for internal server errors across album, image, and node operations
go.mod Updated github.com/bzimmer/smugmug dependency from v0.8.2 to v0.8.3
go.sum Updated checksums for the new smugmug package version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bzimmer bzimmer merged commit 5aaaf2c into main Dec 25, 2025
14 checks passed
@bzimmer bzimmer deleted the imagesizedetails branch December 25, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant