Conversation
bzimmer
commented
Dec 25, 2025
- improved debug and error logging
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 89.85% 90.22% +0.36%
==========================================
Files 14 14
Lines 1272 1279 +7
==========================================
+ Hits 1143 1154 +11
+ Misses 78 76 -2
+ Partials 51 49 -2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request adds ImageSizeDetails to the expansions used when retrieving images and albums, and enhances observability by adding structured debug and error logging throughout the ls command. The dependency on github.com/bzimmer/smugmug is updated from v0.8.2 to v0.8.3 to support these changes.
Key changes:
- Added
ImageSizeDetailsexpansion to image and album retrieval operations to fetch additional size metadata - Implemented structured logging using zerolog for all three resource types (image, album, node) with appropriate context fields
- Added comprehensive test coverage for internal server error scenarios
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ls.go | Added ImageSizeDetails to expansions for image and album operations; added debug logging before API calls and error logging after failures for all three resource types |
| ls_test.go | Added test cases and mock handlers to verify error handling for internal server errors across album, image, and node operations |
| go.mod | Updated github.com/bzimmer/smugmug dependency from v0.8.2 to v0.8.3 |
| go.sum | Updated checksums for the new smugmug package version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.