Skip to content

Remove the filterFunc param from prepareForSerialization #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentfretin merged 1 commit into from
Feb 22, 2026
Merged

Remove the filterFunc param from prepareForSerialization #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions src/lib/entity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,7 @@ function recursivelyRegenerateId(element) {
export function cloneEntityImpl(entity) {
entity.flushToDOM();
const clone = prepareForSerialization(entity);
if (clone !== null) {
recursivelyRegenerateId(clone);
}
recursivelyRegenerateId(clone);
return clone;
}

Expand Down Expand Up @@ -175,15 +173,9 @@ export function getEntityClipboardRepresentation(entity) {
* primitive attributes, mixins and defaults.
*
* @param {Element} entity Root of the DOM hierarchy.
* @param {Function} filterFunc Function to filter out nodes from the serialization
* @return {Element} Copy of the DOM hierarchy ready for serialization.
*/
export function prepareForSerialization(
entity,
filterFunc = (entity) => !entity.classList.contains('autocreated')
) {
if (!filterFunc(entity)) return null;

export function prepareForSerialization(entity) {
var clone = entity.cloneNode(false);
var children = entity.childNodes;
for (var i = 0, l = children.length; i < l; i++) {
Expand All @@ -197,10 +189,8 @@ export function prepareForSerialization(
!child.classList.contains('hitEntity') && // entity created by blink-controls
!child.parentElement.hasAttribute('environment')) // children of the environment entity
) {
const childClone = prepareForSerialization(children[i], filterFunc);
if (childClone !== null) {
clone.appendChild(childClone);
}
const childClone = prepareForSerialization(children[i]);
clone.appendChild(childClone);
}
}
optimizeComponents(clone, entity);
Expand Down Expand Up @@ -829,9 +819,8 @@ export function elementToObject(element) {
*/
export function exportEntityToObject(entity) {
entity.flushToDOM();
// prepare entity for serialization and check if it's blacklisted
// prepare entity for serialization
const preparedElement = prepareForSerialization(entity);
if (!preparedElement) return null;
// convert entity to object
const entityObj = elementToObject(preparedElement);

Expand Down