Correct description of simulator m option#1671
Open
evgaster wants to merge 9 commits intoc3d:stablefrom
Open
Conversation
While investigating issue c3d#1574 it appeared the definitions of re and rp contained errors. The definition of rp was missing its label. The definition of σe had an incorrect unit in its label. Above errors are corrected. Unfotunately this doesn't solve the issue. A Signed-off-by: Ed@vanGasteren.net
The test for the Proton charge radius tested for a wrong value. The value was corrected previously, but not the test. The value tested for is corrected. Signed-off-by: Ed@vanGasteren.net
In c3d#1574 (comment) a better value is proposed. Left out calls to UVAL. It is not needed. Signed-off-by: Ed@vanGasteren.net
Signed-off-by: Ed@vanGasteren.net
Signed-off-by: Ed@vanGasteren.net
Author
|
Sorry again about the non related commits that keep popping up. I wish I could get rid of them ... for good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.