Open
Conversation
ineiti
requested changes
May 31, 2024
Member
ineiti
left a comment
ineiti
left a comment
There was a problem hiding this comment.
This will in fact not work: your changes are still in the c4dt/student_24_dela_libp2p repo. I thought you only pushed the changes to the scripts regarding the debugging capabilities.
To push the full changes, we'll have to merge your c4dt/student_24_dela_libp2p first to c4dt/dela.
Comment on lines
+4
to
+25
| // | ||
| // # Expect GOPATH to be correctly set to have dvoting available. | ||
| // go install | ||
| // | ||
| // dvoting --config /tmp/node1 start --port 2001 & | ||
| // dvoting --config /tmp/node2 start --port 2002 & | ||
| // dvoting --config /tmp/node3 start --port 2003 & | ||
| // | ||
| // # Share the different certificates among the participants. | ||
| // dvoting --config /tmp/node2 minogrpc join --address 127.0.0.1:2001\ | ||
| // $(dvoting --config /tmp/node1 minogrpc token) | ||
| // dvoting --config /tmp/node3 minogrpc join --address 127.0.0.1:2001\ | ||
| // $(dvoting --config /tmp/node1 minogrpc token) | ||
| // | ||
| // # Create a chain with two members. | ||
| // dvoting --config /tmp/node1 ordering setup\ | ||
| // --member $(dvoting --config /tmp/node1 ordering export)\ | ||
| // --member $(dvoting --config /tmp/node2 ordering export) | ||
| // | ||
| // # Add the third after the chain is set up. | ||
| // dvoting --config /tmp/node1 ordering roster add\ | ||
| // --member $(dvoting --config /tmp/node3 ordering export) |
| // in two blocks. Node 4 does not share its certificate which means others won't | ||
| // be able to communicate, but the chain should proceed because of the | ||
| // threshold. | ||
| func TestDvoting_Scenario_SetupAndTransactions(t *testing.T) { |
Member
There was a problem hiding this comment.
Does this test actually work? It looks like a grpc-mino test to me.
| // finally restarts both of them to make sure the chain can proceed after the | ||
| // restart. It basically tests if the components are correctly loaded from the | ||
| // persisten storage. | ||
| func TestDvoting_Scenario_RestartNode(t *testing.T) { |
Member
There was a problem hiding this comment.
This also looks like a mino-grpc test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request with this project, please also:
draftmode andin progresspipeline in the project (if applicable)RevieworReady4Mergepipeline in the project (if applicable)draft