Commit all changes in addition to version changes #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…treated as strings.
ekohl
requested changes
Mar 14, 2022
Collaborator
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Could you please leave out the version bumping?
I also wonder about this feature. It makes the allow_dirty option kind of pointless, doesn't it? Should this be default behavior or something to opt into?
Author
|
In the future I will pull out the version bumping, and yes it conflicts
with allow_dirty. I thought about adding another parameter that was
mutually exclusive with allow dirty. If you are making a commit of the
version files, it doesn't make sense to me not to commit the tracked files,
tags really become worthless since all the code is not present in the
library.
AJ Reynolds
…On Mon, Mar 14, 2022 at 5:26 AM Ewoud Kohl van Wijngaarden < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Could you please leave out the version bumping?
I also wonder about this feature. It makes the allow_dirty option kind of
pointless, doesn't it? Should this be default behavior or something to opt
into?
—
Reply to this email directly, view it on GitHub
<#245 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB64OVPKC5QQVKKX3OSZVNLU74H3ZANCNFSM5QT4UZKQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the lists of files to be commited to include all files being tracked.