fix: oncoTree rendering multiple times#285
Open
NishchayRajput wants to merge 1 commit intocBioPortal:masterfrom
Open
fix: oncoTree rendering multiple times#285NishchayRajput wants to merge 1 commit intocBioPortal:masterfrom
NishchayRajput wants to merge 1 commit intocBioPortal:masterfrom
Conversation
Contributor
Author
|
Please review @ritikakundra |
Contributor
|
adding @bprize15 to this |
bprize15
requested changes
Feb 28, 2025
| const versionChanged = dataRef.current !== oncoTreeData; | ||
|
|
||
| if (treeContainerRef.current && versionChanged) { | ||
| if (treeContainerRef.current && versionChanged && !isInitialized) { |
Collaborator
There was a problem hiding this comment.
This will disable the version change functionality so we cannot add this condition.
What you are observing is not a bug. This is due to React's Strict Mode which runs each useEffect twice in development.
However, in production, you can observe a similar bug when you navigate directly to the website without the version URL param first. This is because it fetches the default version automatically, and then again when the version is set via URL param. This is definitely worth looking into. Appreciate the effort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At home page the OncoTree was rendering multiple time over reaload
Screencast.from.25-01-25.02.40.50.PM.IST.webm
It was due to the useEffect triggering multiple times. So once the tree is initialise it shouldn't be triggered again.
Video after making changes.
Screencast.from.25-01-25.02.41.23.PM.IST.webm