Humble rework

[cKohl10]

No description provided.

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Bug: Function Assigned Instead of Path

On line 9, os.getcwd is assigned without being called, which makes current_direc a function object instead of the current directory path string. This incorrect value is then embedded into the run.sh script on line 16, likely causing issues with script directory resolution.

 

[cursor]

Bug: Baseline Update Error Causes Calibration Issues

In baseline_tracking_status_callback, self.baseline_values is updated by subtracting the old baseline from self.sensor_values. This appears to be an unintended subtraction, as the intent is to set the baseline directly to the current sensor values. This causes baseline_values to represent a delta, leading to incorrect sensor calibration.

 

[cursor]

Bug: Missing Parentheses in os.getcwd Call

The os.getcwd call on line 9 is missing parentheses, assigning the function object itself to current_direc instead of the current directory path. This results in an invalid bash script being generated, as the f-string embeds the function object's string representation.

 

[cursor]

Bug: Uninitialized Attribute Causes Method Errors

The self.joint_names attribute is used in move_to_home() and timer_callback() but is never initialized in the __init__ method. This results in an AttributeError when these methods are called.

Additional Locations (1)

• gentact_ros_tools/franka_ros2_controller.py#L92-L100

 

[cursor]

Bug: Intensity Value Mismatch in Point Cloud

The _transform_point function appends point[2] as the PointCloud2 intensity value. For out-of-range sensors, point[2] is set to 10000 * self.max_distance, which differs from the self.max_distance*1000 published to /sensor_dist. This inconsistency results in misleading intensity values in the point cloud.