feat: support string hlc #21
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20.
Notes:
I also started working on adding a test case to
sqlite_crdt.Here’s what I’ve done so far:
However, when running this (with the updated
crdtpackage), I get the following error:This happens because the
querymethod in theExecutorApiclass returns aQueryRowobject, which is "immutable" and cannot be modified.I came up with two possible solutions:
1) Update
ExecutorApi’squerymethod to copy the row maps before returning themThis ensures the returned data is mutable.
I don’t think this is the cleanest solution, but it works.
2) Update
SqlCrdt'smergemethod to copy the record before updating it:Let me know which approach you prefer.
Also, should I file a separate issue for this problem?