Conversation
Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a94cf6d3a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| process.executableURL = URL(fileURLWithPath: "/usr/bin/which") | ||
| process.arguments = [tool] | ||
| process.standardOutput = pipe | ||
| process.standardError = FileHandle.nullDevice |
There was a problem hiding this comment.
toolExists now runs /usr/bin/which without setting process.environment, so it relies on the app’s inherited PATH. In macOS GUI launches (e.g., from Finder), PATH often omits Homebrew locations like /opt/homebrew/bin, which makes which brew/which npm fail even when installed. Because resolvedPaths skips .probed entries when requiresTool is missing (CacheCategory.swift around lines 149-153), this regression can hide entire cache categories and prevents fallback paths from being considered for common setups.
Useful? React with 👍 / 👎.
1 participant
This PR introduces a defense-in-depth security enhancement by refactoring the
toolExistsfunction inCacheCategory.swift. The previous implementation used string interpolation within a shell wrapper command (shell("/usr/bin/which \(tool)")), which is a pattern susceptible to command injection. Although the currenttoolparameter is not user-controlled, replacing this with a directProcessexecution ensures robust security by safely passing the tool name within the argument array, mitigating future risks.PR created automatically by Jules for task 14710441264483619177 started by @acebytes