Open
Conversation
* sink.h and sink.disabled.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sink.handsink.disabled.hhave identical header guards, because of which I couldn't build my project with cactus-rt linked.This was the only issue and the build then succeeded as expected.
As the
CACTUS_RT_TRACING_ENABLEDcompiler option is set by default, these header should not be included. I'm not sure why the compiler then went ahead and looked for required definitions in ALL headers, even those that should not be included - I'm a bit out of my depth here.Anyways, now it works for me and is synchronized with how the rest of the header guards in
include/tracingare defined.Byeee