Open
Conversation
Newer tokens from Cloudflare are longer as they have a prefix to indicate user or account tokens
|
I was struck by this issue as well. Please merge |
|
Literally came to github to do a PR for a fix for exactly this, modified the regex and it worked like a charm. |
|
Also came to github to do a PR for this fix 👍 |
|
Also also came to GitHub to open a PR to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer tokens from Cloudflare are longer as they have a prefix to indicate user or account tokens. Increased regex from 50 to 55 characters to account for
cfutorcfat(i think that was the one for accounts, but havent tested since early debug) prefixsee https://caddy.community/t/caddy-tailscale-cloudflare-certificate-issue/33585/5 for more details.
My setup did not work before, and now it worked flawlessly. Hopefully this can be merged , so I can point to an official release.
Thank you for your hard work on getting this all together, this bump was painful but nothing compared to the work put in by the devs of caddy and caddy-cloudflare.