Add ActivityContext #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Sep 9, 2025
| return await self._activity_fn(*params) | ||
|
|
||
| async def _to_params(self, payload: Payload) -> list[Any]: | ||
| type_hints = get_fn_parameters(self._activity_fn) |
There was a problem hiding this comment.
nit: store in self._activity_fn_args_type_hints to avoid unnecessary evaluations.
shijiesheng
approved these changes
Sep 9, 2025
shijiesheng
approved these changes
Sep 9, 2025
User code needs to be able to retrieve information about the running activity, and in the future will be able to interact with it (heartbeating). Create the initial structure for providing it.
natemort
force-pushed
the
activity_context
branch
from
88b7b0c to
c9866a0
Compare
timl3136
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User code needs to be able to retrieve information about the running activity, and in the future will be able to interact with it (heartbeating). Create the initial structure for providing it.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes