feat: Implement signal_with_start_workflow client method #44
+156
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Li <ltim@uber.com>
shijiesheng
reviewed
Nov 3, 2025
Signed-off-by: Tim Li <ltim@uber.com>
…n-client into signal_with_start Signed-off-by: Tim Li <ltim@uber.com>
Signed-off-by: Tim Li <ltim@uber.com>
Resolved conflicts: - Added Generic import to support Generic[C] type parameter - Removed unused TYPE_CHECKING import and empty block - Removed client() method from WorkflowContext (removed in upstream) - Removed test_workflow_engine_integration.py as upstream reorganized tests - Adopted upstream's frozen=True for WorkflowInfo
natemort
reviewed
Nov 25, 2025
cadence/client.py
Outdated
| self, | ||
| workflow: Union[str, WorkflowDefinition], | ||
| signal_name: str, | ||
| signal_input: Any = None, |
Member
There was a problem hiding this comment.
I think we similarly want a list here
| Test cases: | ||
| 1. new_workflow: SignalWithStartWorkflow starts a new workflow if it doesn't exist | ||
| 2. existing_workflow: SignalWithStartWorkflow signals existing workflow without restart |
Member
There was a problem hiding this comment.
While these two scenarios are testing different behaviors, they're largely testing server behaviors rather than client behaviors. In both scenarios the client sends the same data. I think just one of them is fine.
I'd expand the test to verify that the workflow history actually has the signal event and that the payload/name match what we expect, since that's demonstrating end to end that we can signal a specific workflow.
Signed-off-by: Tim Li <ltim@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implement signal_with_start_workflow client method
Why?
It's a necessary feature for signaling in python client
How did you test it?
Add an integration test to test signal_with_start.
Potential risks
Release notes
Documentation Changes