fix: replace npx esbuild with direct API to fix pnpm warnings #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using npx to run esbuild was causing npm warnings when users ran aocrunner with pnpm. This happened because pnpm exports its config as npm_config_* environment variables, which npm doesn't recognize. Switched to importing and calling the esbuild API directly instead of spawning a subprocess. This makes the build process work cleanly with any package manager and removes the subprocess overhead. Made buildSource, build, and dev functions async to support the new esbuild API calls. Updated tsconfig to es2022 to enable top-level await in the CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using npx to run esbuild was causing npm warnings running aocrunner with pnpm. This happened because pnpm exports its config as npm_config_* environment variables, which npm doesn't recognize.
Switched to importing and calling the esbuild API directly instead of spawning a subprocess. This makes the build process work cleanly with any package manager and removes the subprocess overhead.
Made buildSource, build, and dev functions async to support the new esbuild API calls. Updated tsconfig to es2022 to enable top-level await in the CLI.