Skip to content

Activated Sludge Model ASM3h #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cbix wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

Activated Sludge Model ASM3h #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
d5ff5d5
initial concept
AntoniaBerger May 13, 2025
cd09ef8
ASM3: compute p2-5
cbix May 13, 2025
cd8d388
ASM3: compute r6-12
cbix May 13, 2025
3c56f72
ASM3: set up parameters and derived variables
cbix May 13, 2025
9971358
register model and jacobian equation as pseudo code
AntoniaBerger May 14, 2025
12a5b67
ASM3: add Aeration
cbix May 14, 2025
5e65317
ASM3: basic stoichiometry definition
cbix May 14, 2025
26d0ff1
ASM3: parameter set required for stoichiometry
cbix May 14, 2025
d07851e
ASM3: differentiate p1-5
cbix May 14, 2025
8bb2dff
ASM3: differentiate r6-12
cbix May 14, 2025
acabe81
ASM3: compute jacobian
cbix May 14, 2025
5af98cf
add ad test
AntoniaBerger May 14, 2025
47c5378
Merge branch 'feature/ActiveSludgeModel3' of github.com:modsim/CADET …
AntoniaBerger May 14, 2025
055af7f
get parameter from parameterprovider
AntoniaBerger May 14, 2025
ff508ae
ASM3: set up params for codegen
cbix May 14, 2025
564fc8c
add ASM3 to factory
AntoniaBerger May 14, 2025
15e7864
Merge branch 'feature/ActiveSludgeModel3' of github.com:modsim/CADET …
AntoniaBerger May 14, 2025
b3660e7
ASM3: fix codegen json
cbix May 14, 2025
f704613
ASM3: use scalar external params
cbix May 14, 2025
c36c198
fix parameter
AntoniaBerger May 14, 2025
324a1da
Merge branch 'feature/ActiveSludgeModel3' of github.com:modsim/CADET …
AntoniaBerger May 14, 2025
49dd73c
ASM3: fix jacobian computation
cbix May 14, 2025
e78df34
overload ScalarParameter methods for reaction model compatibility
cbix May 14, 2025
507847c
parameter declariation and jacobian fix
AntoniaBerger May 15, 2025
0750d08
fic internal variable determination numbered value int-> double
AntoniaBerger May 15, 2025
785dd6c
ASM3: start documenting parameters
cbix May 17, 2025
ee896db
ASM3: document remaining params from SIMBA#
cbix May 19, 2025
ce294c2
fix lost of jacobi equaitons
AntoniaBerger May 19, 2025
e133544
Merge branch 'feature/ActiveSludgeModel3' of github.com:cadet/CADET-C…
AntoniaBerger May 19, 2025
3a34839
ASM3: fix doc typos
cbix May 19, 2025
d56bda7
Merge branch 'master' of https://github.com/cadet/cadet-core into fea…
cbix May 19, 2025
1773de2
ASM3: use ScalarParameter fix from #412
cbix May 19, 2025
69a968f
add jacobian test and fix jacobian
AntoniaBerger May 20, 2025
844f2fc
Merge branch 'feature/ActiveSludgeModel3' of github.com:cadet/CADET-C…
AntoniaBerger May 20, 2025
2ce03de
add AD test only for reactions in liquit phase
AntoniaBerger May 20, 2025
5e1c124
ASM3: group parameter documentation
cbix May 20, 2025
bcebcee
Merge branch 'master' of https://github.com/cadet/cadet-core into fea…
cbix May 27, 2025
8473f77
change parameter name to lowercase
AntoniaBerger Jun 6, 2025
94a0a99
add example set up for cadet_python to doc
AntoniaBerger Jun 6, 2025
1d92cd1
fixup! add example set up for cadet_python to doc
AntoniaBerger Jun 6, 2025
ad9355f
start error messaging
AntoniaBerger Jun 7, 2025
8ab57cf
configurable component index
cbix Jun 21, 2025
3f406b1
check ASM3_COMP_IDX exists before reading
cbix Jun 22, 2025
a39e4cd
document ASM3_COMP_IDX, use bold sub headings
cbix Jun 22, 2025
775b437
update stoichimoetry using custom indexes
cbix Jun 22, 2025
8614939
Merge branch 'master' of https://github.com/cadet/cadet-core into fea…
cbix Jun 23, 2025
05c40fd
Seperation of SS and SI and flexible index for jacobinan
AntoniaBerger Jun 30, 2025
f334197
fixup! Seperation of SS and SI and flexible index for jacobinan
AntoniaBerger Jun 30, 2025
12a4376
Add time dependent fraction
AntoniaBerger Jun 30, 2025
b0f2bfc
clean up for fractionate option
AntoniaBerger Aug 4, 2025
5f9c910
Merge branch 'master' of https://github.com/cadet/cadet-core into fea…
AntoniaBerger Jan 15, 2026
7ce0eca
asm3: fix warning when using fractionated SS/SI
cbix Sep 15, 2025
cbe3257
change internal parameter names
AntoniaBerger Nov 19, 2025
8a5669a
fix ASM3 test
AntoniaBerger Nov 19, 2025
f68248d
rebase
AntoniaBerger Jan 15, 2026
7e65d1c
Add simulation test (without adsoption vs with adsoption components)
AntoniaBerger Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
529 changes: 529 additions & 0 deletions doc/interface/reaction/activated_sludge_model.rst
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions doc/interface/reaction/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ The input group for parameters of single reactions is given by ``phase_reaction_

mass_action_law
michaelis_menten_kinetics
activated_sludge_model


Cross Phase Reactions
Expand Down
Loading
Loading