Skip to content

Add MCT option to test_dll #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hannahlanzrath wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add MCT option to test_dll #50

hannahlanzrath wants to merge 2 commits into from

Conversation

@hannahlanzrath
Copy link
Collaborator

@hannahlanzrath hannahlanzrath commented Feb 26, 2025 •
edited
Loading

This PR adds an option to test the MCT to the test_dll.

We should also think about #47.

@hannahlanzrath hannahlanzrath mentioned this pull request Feb 26, 2025
Closed
@schmoelder
Copy link
Contributor

schmoelder commented Mar 10, 2025

The issue here is that the createLWE method of CADET-Core does not support the MULTI_CHANNEL_TRANSPORT model (see cadet/CADET-Core#268).
We had decided to not further expand the features of of createLWE on the C++ side since it is only used for generating configuration files which we would prefer to do in Python (which also avoids a lot of duplication). I'm not opposed to adding this to CADET-Core but I think we should discuss the general direction for managing our collection of test cases with @jbreue16.

@schmoelder schmoelder marked this pull request as draft March 17, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hannahlanzrath hannahlanzrath

@daklauss daklauss

Labels

None yet

Projects

CADET Repositories
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hannahlanzrath @schmoelder @daklauss