Skip to content

Conversation

@luketpickering
Copy link
Contributor

No description provided.

@cjbacchus
Copy link
Contributor

Why all the changes to _sincos()? Why not put a definition of sincos() in terms of __sincos() inside an if-apple test, same as with the stan implementation? That would lead to less churn, and less need to remember that we did something weird because Apple.

CXX := $(shell if [[ x${QUALIFIER} == *c7* ]]; then echo 'clang++'; else echo 'g++'; fi )

LDFLAGS := -L${ROOTSYS}/lib -lCore -L${GSL_LIB} -lgsl -lgslcblas
LDFLAGS := -L${ROOT_LIB} -lCore -lHist -L${GSL_LIB} -lgsl -lgslcblas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ROOTSYS/lib -> $ROOT_LIB doesn't work on the default gpvm ups build, because apparently that package doesn't define $ROOT_LIB. Could you work some more makefile magic to have this work in both cases?

@cjbacchus
Copy link
Contributor

I cherry-picked all the non-sincos parts of this into #10 and added my own sincos solution. If that looks good, I will merge that one.

Except, we still need a generic solution for finding the ROOT library directory. If you can commit a fix for that somewhere I will patch up the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants