Skip to content

fix(integrity): dedupe packageIds when counting resolved packages (#506) #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggreif wants to merge 1 commit into from
+8 −3
Closed

fix(integrity): dedupe packageIds when counting resolved packages (#506) #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cli/integrity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,16 @@ export async function checkLockFile(force = false) {
}
}

// check number of packages
if (Object.keys(lockFileJson.hashes).length !== packageIds.length) {
// check number of packages — packageIds can contain duplicates when
// multiple aliases (e.g. `base`, `base@0`, `base@0.16`) resolve to the
// same package@version, while lockFileJson.hashes is keyed by packageId
// and naturally deduplicated. Compare unique counts to avoid a spurious
// mismatch.
let uniquePackageIdCount = new Set(packageIds).size;
if (Object.keys(lockFileJson.hashes).length !== uniquePackageIdCount) {
console.error("Integrity check failed");
console.error(
`Mismatched number of resolved packages: ${JSON.stringify(Object.keys(lockFileJson.hashes).length)} vs ${JSON.stringify(packageIds.length)}`,
`Mismatched number of resolved packages: ${JSON.stringify(Object.keys(lockFileJson.hashes).length)} vs ${JSON.stringify(uniquePackageIdCount)}`,
);
process.exit(1);
}
Expand Down
Loading