Skip to content

Optimize Array.fromIter#486

Open
timohanke wants to merge 3 commits intocaffeinelabs:mainfrom
research-ag:mrr/array-from-iter
Open

Optimize Array.fromIter#486
timohanke wants to merge 3 commits intocaffeinelabs:mainfrom
research-ag:mrr/array-from-iter

Conversation

@timohanke
Copy link
Copy Markdown
Contributor

Makes it 20% faster.

@timohanke timohanke requested a review from a team as a code owner April 12, 2026 18:33
Copy link
Copy Markdown
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!

@ggreif ggreif requested a review from rvanasa April 13, 2026 07:16
@timohanke
Copy link
Copy Markdown
Contributor Author

timohanke commented Apr 13, 2026

Good changes!

Did the same for VarArray.fromIter then.

Background why to optimise this particular function? Because it arises when migrating base/Buffer to core. It is one of the possible migrations, applicable to certain uses of Buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants