Skip to content

feat: pretty mut assign errors#5889

Draft
christoph-dfinity wants to merge 4 commits intomasterfrom
christoph/pretty-mut-assign-error
Draft

feat: pretty mut assign errors#5889
christoph-dfinity wants to merge 4 commits intomasterfrom
christoph/pretty-mut-assign-error

Conversation

@christoph-dfinity
Copy link
Copy Markdown
Contributor

Adds a Zipper structure that allows traversing the AST to report errors with more context.

The Zipper was generated by Claude for the most part

@christoph-dfinity christoph-dfinity force-pushed the christoph/pretty-mut-assign-error branch from f3588c9 to ba3c442 Compare March 3, 2026 10:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

Comparing from c925369 to 6480ef6:
The produced WebAssembly code seems to be completely unchanged.
In terms of gas, no changes are observed in 5 tests.
In terms of size, no changes are observed in 5 tests.

@christoph-dfinity christoph-dfinity force-pushed the christoph/pretty-mut-assign-error branch 4 times, most recently from 05c5e45 to e1aade5 Compare March 5, 2026 12:32
@christoph-dfinity
Copy link
Copy Markdown
Contributor Author

Working a bit with the Zipper structure and after doing some changes I spotted nodes it doesn't traverse. The int index also makes it trickier to work with AST nodes that have lots of optional/variable length children.
I'm thinking about changes to make it work, but I'll let it "marinate" for a while before spending more time on it.

Adds a Zipper structure that allows traversing the AST to report
errors with more context.
@christoph-dfinity christoph-dfinity force-pushed the christoph/pretty-mut-assign-error branch from e1aade5 to 910c1c7 Compare March 11, 2026 09:36
Provides a .mli file encapsulating implementation details, and provides
a more idiomatic interface
@christoph-dfinity christoph-dfinity force-pushed the christoph/pretty-mut-assign-error branch from 910c1c7 to 6480ef6 Compare March 11, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant