fix: don't attempt to read files for errors with no region#5976
Merged
christoph-dfinity merged 2 commits intomasterfrom Apr 7, 2026
Merged
fix: don't attempt to read files for errors with no region#5976christoph-dfinity merged 2 commits intomasterfrom
christoph-dfinity merged 2 commits intomasterfrom
Conversation
christoph-dfinity
force-pushed
the
christoph/human-error-no-region
branch
2 times, most recently
from
f1f3de4 to
f3db863
Compare
This’ll make it easier to provide a custom file reader in the JS build of the compiler in the future. Also moves some code around for readability.
christoph-dfinity
force-pushed
the
christoph/human-error-no-region
branch
from
f3db863 to
724b50a
Compare
Contributor
crusso
reviewed
Apr 7, 2026
Contributor
crusso
left a comment
crusso
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing so quickly!
crusso
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5974
I split changes into two commits to make the refactoring portion easier to review in isolation.