Close remaining probe contracts and add validation visual gate#3
Merged
iahncajigas merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- closes remaining probe-only MATLAB-compat methods by adding explicit behavior contracts (probe_verified -> 0)\n- tightens functional parity policy to require 480 explicit contracts and zero probe-verified methods\n- adds CI visual gate script to fail on duplicate PDF pages or topics with zero unique figures\n- wires visual gate into scheduled validation PDF workflow\n- regenerates parity artifacts and dashboard with updated metrics\n\n## Validation\n- pytest -q\n- mypy src/nstat\n- python tools/parity/check_functional_parity_progress.py --report parity/function_example_alignment_report.json --policy parity/functional_gate_policy.yml\n- python tools/parity/build_numeric_drift_report.py --fixtures-manifest tests/parity/fixtures/matlab_gold/manifest.yml --thresholds parity/numeric_drift_thresholds.yml --report-out parity/numeric_drift_report.json --fail-on-violation\n- python tools/reports/check_validation_visuals.py --report-pdf 'output/pdf/*.pdf' --images-root tmp/pdfs/validation_report/notebook_images --min-unique-images-per-topic 1 --max-duplicate-pdf-pages 0\n