Skip to content

Fix nspikeTrain.plot() handle kwarg for API consistency #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iahncajigas merged 1 commit into from
Mar 10, 2026
Merged

Fix nspikeTrain.plot() handle kwarg for API consistency #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nstat/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1946,10 +1946,10 @@ def plotExponentialFit(self, minTime: float | None = None, maxTime: float | None
fig.tight_layout()
return fig

def plot(self, dHeight: float = 1.0, yOffset: float = 0.5, currentHandle=None):
def plot(self, dHeight: float = 1.0, yOffset: float = 0.5, currentHandle=None, handle=None):
import matplotlib.pyplot as plt

ax = plt.gca() if currentHandle is None else currentHandle
ax = plt.gca() if (currentHandle is None and handle is None) else (currentHandle or handle)
lines = []
for spike_time in self.spikeTimes:
(line,) = ax.plot(
Expand All @@ -1958,7 +1958,7 @@ def plot(self, dHeight: float = 1.0, yOffset: float = 0.5, currentHandle=None):
"k",
)
lines.append(line)
if currentHandle is None:
if currentHandle is None and handle is None:
xunits = f" [{self.xunits}]" if self.xunits else ""
yunits = f" [{self.yunits}]" if self.yunits else ""
ax.set_xlabel(f"{self.xlabelval}{xunits}")
Expand Down