don't render templates if the template tag is blank#159
Open
PetrDlouhy wants to merge 1 commit intocaktus:masterfrom
Open
don't render templates if the template tag is blank#159PetrDlouhy wants to merge 1 commit intocaktus:masterfrom
PetrDlouhy wants to merge 1 commit intocaktus:masterfrom
Conversation
PetrDlouhy
force-pushed
the
performance-improvements
branch
from
e2784c5 to
223c1a1
Compare
Contributor
Author
|
I have added generating the blank scribble content at startup, and also moved loading of the template to global level, so it is done only once. |
Contributor
Author
|
@ronardcaktus Could you please also look at this small optimization? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #158
The rendering of templates take ~10ms per scribble even if it's content is completely blank.
This returns simply blank DIV in that case. Other changes are just rearranging order of commands, that shouldn't have influence on data processing.
This introduces small incompatibility - if the template was overriden by user, the blank output could differ. I would probable rewrite this, so that it would generate blank content once at startup.