Adding request context to scribble context#178
Open
PetrDlouhy wants to merge 3 commits intocaktus:masterfrom
Open
Adding request context to scribble context#178PetrDlouhy wants to merge 3 commits intocaktus:masterfrom
PetrDlouhy wants to merge 3 commits intocaktus:masterfrom
Conversation
Member
|
@PetrDlouhy I will try to take a look at this as soon as I can. |
Contributor
Author
|
@ronardcaktus Thank you very much. Let me know if anything would need to be done for the new release. I am not sure about the tests in this project - it seems that they are just turned off. Maybe if you just turn them on, I could try to make sure this passes them correctly. |
Contributor
Author
|
@ronardcaktus Would you be able to find some time for this, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New take on #115.
I rebased the code to the current
masterand fixed RequestContext problem with new Django.I also addressed the notice about modifying context.
I tested this and the preview works for me fine.
It has blank context, so the variables are blank, but I don't expect them to work in preview and I don't consider it to be a problem. It is still much better than not being able to use variables at all.
The only time the preview didn't work was when I had unclosed
<div>tags in the scribble - then the preview disappeared completely. But that is whole another issue.