Some Slack notification changes #486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One workflow gets triggered per label that was added. For example, in "content" and "resources". Our if statement checked with `contains` against the `issue.labels.*.name` array, which included both labels already since these labels were created alongside the issue; opposed to being added individually. Instead, check that the label triggered this workflow is what we're looking for.
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @thekaveman ! Just looked over this PR and I'm thinking it needs a dev reviewer/approver to proceed - also wanted to call out @allejo 's proposed solution for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedupe Press/Resource Slack Notifications
Reported by @thekaveman, on Slack, the "New Press/Resource Request" Slack notification was reporting the issue twice.
This was fixed in 8e48028.
Report failed Netlify deployment previews to Slack
The Netlify App uses GitHub's pull request status API to communicate when Netlify's website checks fail, succeed, get canceled, etc. We can listen to these status updates and trigger a workflow when they happen.
The context of the status we care for is
netlify/cal-itp-website/deploy-preview, but why make things so strict? I felt like checking the whole string could inadvertently cause problems if we rename the project on Netlify at some point.closes #474
Reporting to Slack on build failures is a paid extra.
We can circumvent this by either hosting or using someone's service to accept POST APIs and translate that into a Slack message.