Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the dylib-workflow project to match a newer Calcit runtime and updated Cirru EDN/parser dependencies, while ensuring the required exported symbols exist under Rust 2024’s unsafe-attribute rules.
Changes:
- Upgraded Rust edition to 2024 and bumped
cirru_edn/cirru_parserdependency versions (with corresponding lockfile updates). - Added a new exported
edn_version()symbol and migrated exports to#[unsafe(no_mangle)]. - Updated Calcit version metadata, removed
calcit.cirru, addedAgents.md, and adjusted CI to invokecr.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Switches exported symbols to #[unsafe(no_mangle)] and adds edn_version() export. |
| Cargo.toml | Moves to Rust 2024 edition and bumps Cirru dependencies. |
| Cargo.lock | Reflects dependency upgrades and transitive changes. |
| deps.cirru | Updates referenced :calcit-version to 0.12.9. |
| calcit.cirru | Removes legacy Calcit project file (appears superseded by compact.cirru). |
| Agents.md | Adds development/verification instructions for the dylib workflow. |
| .gitignore | Ignores .DS_Store. |
| .github/workflows/check.yaml | Changes CI to run cr (no -1). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.