Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project to newer Calcit tooling/runtime versions and refreshes generated snapshots/docs to reflect updated trait/record usage patterns.
Changes:
- Bump
@calcit/procs(and related transitive deps) and update Calcit/dependency versions indeps.cirru. - Regenerate
compact.cirruto migrate severaldefrecord!usages to the newerimpl-traits/defimpl/deftraitstyle, plus some related predicate updates. - Expand/refresh the Calcit agent CLI guidance documentation.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates locked @calcit/procs (+ transitive @cirru/parser.ts) versions. |
| package.json | Bumps @calcit/procs dependency range. |
| llms/Calcit.md | Adds extensive CLI workflow guidance for LLM/agent usage. |
| deps.cirru | Updates :calcit-version and several Calcit module dependency versions. |
| compact.cirru | Regenerated snapshot reflecting new trait/record patterns and updated helpers/usages. |
| calcit.cirru | Minor metadata change in snapshot content. |
| .gitignore | Ignores .yarn/ directory. |
| .gitattributes | Marks .pnp.* as linguist-generated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| :data $ {} | ||
| |T $ %{} :Leaf (:at 1504777353661) (:by |root) (:text |hsl) | ||
| |j $ %{} :Leaf (:at 1504777353661) (:by |root) (:text |0) | ||
| |j $ %{} :Leaf (:at 1771566270665) (:by |S1lNv50FW) (:text |0) |
There was a problem hiding this comment.
This change only updates the :at/:by metadata for a single leaf node in calcit.cirru (no functional change). Since calcit.cirru is typically treated as generated/editor data, please confirm this edit is intentional; otherwise consider reverting to avoid unnecessary churn and attribution/timestamp noise in diffs.
| ````bash | ||
| # Cirru one liner | ||
| cr edit def app.core/multiply -e 'defn multiply (x y) (* x y)' | ||
| # or JSON | ||
| cr edit def app.core/multiply -j '["defn", "multiply", ["x", "y"], ["*", "x", "y"]]' | ||
| ``` | ||
|
|
||
| **更新文档和示例：** | ||
| # 基本操作：** | ||
|
|
There was a problem hiding this comment.
This section opens a 4-backtick code fence (````bash) and then starts a nested 3-backtick fence without closing the first one, which will break Markdown rendering. Also the line # 基本操作：** contains stray `**` inside the code block. Suggest using a single code fence and removing the stray asterisks.
| hint $ if (record? target-node) | ||
| if (&record:matches? target-node schema/CirruLeaf) (:text target-node) nil | ||
| if | ||
| and (record? target-node) | ||
| = :Leaf $ &record:get-name target-node | ||
| :text target-node |
There was a problem hiding this comment.
hint does if (record? target-node) and then immediately checks and (record? target-node) again, which is redundant. Consider removing the duplicate record? check and/or reusing the existing leaf? predicate to keep leaf detection logic consistent.
| sorted-children $ -> (:data expr) (.to-list) (.sort-by first) | ||
| first-id $ if (empty? sorted-children) nil | ||
| first $ first sorted-children | ||
| last-id $ if (empty? sorted-children) nil | ||
| first $ last sorted-children |
There was a problem hiding this comment.
sorted-children is now used to derive first-id/last-id, but get-min-key / get-max-key are still imported in this namespace and no longer referenced. Please remove the unused bisection-key.util refers (or switch back to using them) to avoid dead imports.
No description provided.