fix: atomic authorization code consumption to prevent race condition (#27441)#28856
Draft
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Draft
fix: atomic authorization code consumption to prevent race condition (#27441)#28856ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Conversation
…alcom#27441) Wrap findValidCode + deleteExpiredAndUsedCodes in a Prisma interactive transaction via a new consumeCode method, ensuring two concurrent token exchange requests cannot both redeem the same authorization code (RFC 6749 Section 4.1.2: single-use codes). Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OAuthService.exchangeCodeForTokenshad a race condition — two concurrent requests with the same authorization code could both find it valid before either deleted it, violating RFC 6749 Section 4.1.2 (single-use codes).Changes
consumeCodemethod toAccessCodeRepositorythat wrapsfindFirst+deleteManyin a Prisma interactive transaction ($transaction)OAuthService.exchangeCodeForTokensto callconsumeCodeinstead of the separatefindValidCode+deleteExpiredAndUsedCodescallsWhy a transaction
Without the transaction, the following race can occur:
findValidCode→ finds code → validfindValidCode→ finds code → valid (not yet deleted)deleteExpiredAndUsedCodes→ deletes codeWith the transaction, step 2 would either not find the code (serializable) or block until step 3 completes.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
consumeCodeis called atomically and that a null result (consumed by concurrent request) throwsinvalid_grantChecklist
Generated by Claude Code
Vibe coded by ousamabenyounes