fix: save button stays enabled after saving availability (#26708)#28860
Draft
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Draft
fix: save button stays enabled after saving availability (#26708)#28860ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
ousamabenyounes wants to merge 1 commit intocalcom:mainfrom
Conversation
The formHasChanges comparison referenced `.availability` but the form field is named `schedule`, so `initialValuesRef.current.availability` was always `undefined`. This made the first comparison always true, keeping the save button permanently enabled after any edit. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Save button on the availability schedule page remained enabled after saving changes due to a property name mismatch in the
formHasChangescomparison.Root cause
The comparison checked
initialValuesRef.current.availability, but the form field is namedschedule. Sinceavailabilitywas never populated fromdefaultValues, it was alwaysundefined, making the comparison alwaystrue.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/availability, click any scheduleFiles changed
packages/platform/atoms/availability/AvailabilitySettings.tsx.availability→.schedulepackages/platform/atoms/availability/AvailabilitySettings.test.tsxGenerated by Claude Code
Vibe coded by ousamabenyounes