Fix Makefile to use virtual environment and apply best practices#8
Open
Aboudjem wants to merge 1 commit intocalesthio:mainfrom
Open
Fix Makefile to use virtual environment and apply best practices#8Aboudjem wants to merge 1 commit intocalesthio:mainfrom
Aboudjem wants to merge 1 commit intocalesthio:mainfrom
Conversation
Homebrew Python (PEP 668) blocks bare pip installs. Route all Python/pip commands through .venv, auto-create the venv on first run, and upgrade pip at venv creation. Also adds a help target, distclean, venv dependency on test/lint/preflight targets, and adds .venv/ to .gitignore. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.venv, auto-created on firstmakerun with pip self-upgrade.venv/to.gitignore: Prevents accidentally committing the virtual environmenthelpdefault target: Running baremakenow shows all available targets with descriptionstest,test-contracts,lint, andpreflightnow ensure the venv exists before runningdistcleantarget: Removes caches and the virtual environment for a full resetcleantarget: Use portablefindinstead of Python one-liner for cache removalTest plan
make help— displays all targets with descriptionsmake -n setup— dry-run confirms venv creation, pip routing, and correct command sequencemake setup— full end-to-end install on a clean checkoutmake test— auto-creates venv if missing, then runs pytestmake distclean && make setup— clean slate rebuild🤖 Generated with Claude Code