fix build_ensemble argument typos in example notebooks#20
Open
othertea wants to merge 1 commit intocalico:mainfrom
Open
fix build_ensemble argument typos in example notebooks#20othertea wants to merge 1 commit intocalico:mainfrom
othertea wants to merge 1 commit intocalico:mainfrom
Conversation
othertea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
In the example notebooks, fixes a typo by passing the correct type of argument: the list of ints
[0], instead of the string'0'toSeqNN.build_ensemble(). The current argument results in an error, and[0]is as indicated in https://github.com/calico/baskerville/blob/0a3075fcf04cae747fdb1f090441f0c0ac514b90/src/baskerville/seqnn.py#L222This closes #13.
Type of change
(If applicable) How has this been tested?
I ran the notebooks and verified the cells containing these calls run with the fix. Without this fix, running these cells results in an error.