Conversation
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 3 agents | Quality score: 100% | Review time: 174.8s
🟡 2 warnings. See inline comments.
🤖 Generated by AI Code Reviewer | Review ID: review-37b9fed0
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 3 agents | Quality score: 89% | Review time: 190.6s
🟡 2 warnings, 💡 1 suggestions. See inline comments.
🤖 Generated by AI Code Reviewer | Review ID: review-85a11c21
| @@ -1,5 +1,5 @@ | |||
| [toolchain] | |||
| channel = "1.88.0" | |||
| channel = "1.91.0" | |||
There was a problem hiding this comment.
💡 Dockerfile sync comment but Dockerfile not updated in PR
The comment says to keep the channel in sync with Dockerfile, but the Dockerfile is not included in this diff; verify it was updated separately or include it here.
Suggested fix:
Confirm the Dockerfile has been updated to Rust 1.91.0, or include that change in this PR.
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 3 agents | Quality score: 100% | Review time: 128.5s
🟡 2 warnings, 💡 1 suggestions. See inline comments.
🤖 Generated by AI Code Reviewer | Review ID: review-f0b44db7
| @@ -108,8 +108,9 @@ members = [ | |||
| [workspace.dependencies] | |||
| actix = "0.13.5" | |||
| aes-gcm = "0.10" | |||
There was a problem hiding this comment.
🟡 Stale comment contradicts toolchain update
Comment states 'workspace uses 1.88' but this PR updates toolchain to 1.91.0, making the ~1.0 pin unnecessary and the comment misleading.
Suggested fix:
Either remove the pin constraint (use `version = "1.0"` again) since Rust 1.91 is now available, or update the comment to reflect the actual reason for keeping the pin.
| aes-gcm = "0.10" | ||
| alloy = { version = "1.0", default-features = false, features = ["std", "reqwest", "reqwest-rustls-tls", "essentials"] } | ||
| alloy-transport-http = { version = "1.0", default-features = false, features = ["reqwest", "reqwest-rustls-tls"] } | ||
| # Pinned to ~1.0 so resolution stays on 1.0.x (alloy 1.7+ requires Rust 1.91; workspace uses 1.88) |
There was a problem hiding this comment.
💡 Consider if ~1.0 pinning is still necessary
With Rust 1.91.0, the MSRV constraint that originally motivated pinning alloy to 1.0.x no longer applies; verify if there's another reason to avoid alloy 1.7+.
Suggested fix:
If alloy 1.7+ has no breaking API changes affecting this codebase, consider removing the tilde pin to benefit from newer releases.
| @@ -108,8 +108,9 @@ members = [ | |||
| [workspace.dependencies] | |||
| actix = "0.13.5" | |||
| aes-gcm = "0.10" | |||
There was a problem hiding this comment.
🟡 Stale comment contradicts the PR's changes
The comment states 'workspace uses 1.88' but this PR updates the workspace to Rust 1.91.0, making the comment misleading for future maintainers.
Suggested fix:
Either remove the `~1.0` pin since Rust 1.91 is now available, or update the comment to explain the actual reason for pinning (e.g., API stability, avoiding breaking changes in alloy 1.7+).
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 3 agents | Quality score: 100% | Review time: 138.1s
🟡 1 warnings, 📝 1 nitpicks. See inline comments.
🤖 Generated by AI Code Reviewer | Review ID: review-3670c780
| @@ -108,8 +108,9 @@ members = [ | |||
| [workspace.dependencies] | |||
| actix = "0.13.5" | |||
| aes-gcm = "0.10" | |||
There was a problem hiding this comment.
🟡 Stale comment contradicts the toolchain bump
The comment says 'workspace uses 1.88' but this PR updates rust-toolchain.toml to 1.91.0; the pin rationale no longer applies and may mislead future maintainers.
Suggested fix:
Either remove the ~1.0 pin since the workspace now satisfies alloy 1.7+ requirements, or update the comment to reflect the actual reason for keeping the pin (e.g., stability preference).
| @@ -108,8 +108,9 @@ members = [ | |||
| [workspace.dependencies] | |||
| actix = "0.13.5" | |||
| aes-gcm = "0.10" | |||
There was a problem hiding this comment.
📝 Nit: Stale comment - workspace now uses Rust 1.91
The comment says 'workspace uses 1.88' but this PR updates the toolchain to 1.91.0; if the ~1.0 pin is still desired for stability reasons, the comment should reflect the actual rationale.
Suggested fix:
Update comment to explain the real reason for pinning (e.g., avoiding breaking changes in alloy 1.7+) or remove the pin if it's no longer needed.
1914c22 to
80cae78
Compare
There was a problem hiding this comment.
🤖 AI Code Reviewer
Reviewed by 3 agents | Quality score: 83% | Review time: 221.0s
🟡 1 warnings, 📝 1 nitpicks. See inline comments.
🤖 Generated by AI Code Reviewer | Review ID: review-a91df431
| aes-gcm = "0.10" | ||
| alloy = { version = "1.0", default-features = false, features = ["std", "reqwest", "reqwest-rustls-tls", "essentials"] } | ||
| alloy-transport-http = { version = "1.0", default-features = false, features = ["reqwest", "reqwest-rustls-tls"] } | ||
| # Pinned to ~1.0 so resolution stays on 1.0.x (alloy 1.7+ requires Rust 1.91; workspace uses 1.88) |
There was a problem hiding this comment.
🟡 Comment references outdated Rust version
The comment says 'workspace uses 1.88' but this PR updates the workspace to 1.91, making the comment incorrect.
Suggested fix:
Update the comment to: '# Pinned to ~1.0 so resolution stays on 1.0.x (alloy 1.7+ requires Rust 1.91)' or remove the Rust version reference entirely since the constraint is now satisfied.
| @@ -108,8 +108,9 @@ members = [ | |||
| [workspace.dependencies] | |||
| actix = "0.13.5" | |||
| aes-gcm = "0.10" | |||
There was a problem hiding this comment.
📝 Nit: Comment is stale after toolchain upgrade
The comment says 'workspace uses 1.88' but this PR updates the toolchain to 1.91.0, making the stated reason for pinning ~1.0 no longer accurate.
Suggested fix:
Update comment to reflect the new Rust version, or remove the pinning constraint since alloy 1.7+ should now be compatible.
E2E Blockchain Proposals FailedThe following proposal workflow(s) failed:
Please check the workflow logs for more details. |
feat: cargo update
Note
Medium Risk
Primarily a dependency/toolchain upgrade; risk is moderate due to broad transitive crate updates and potential build/runtime behavior changes across the workspace.
Overview
Bumps the build toolchain to Rust
1.91.0(viarust-toolchain.toml) and aligns Docker build images (Dockerfile,Dockerfile.auth,Dockerfile.relayer) to use the same Rust version.Refreshes workspace dependencies (
Cargo.toml/Cargo.lock) and updatescalimero_primitives::utilstests to tolerate Rust 1.91+type_namelifetime formatting (stripping'_before assertions).Written by Cursor Bugbot for commit 80cae78. This will update automatically on new commits. Configure here.