Skip to content

fix(android): resolve "Scrapped or attached views may not be recycled" crash #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thanhcuong1990 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): resolve "Scrapped or attached views may not be recycled" crash #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions android/src/main/java/com/reactnativepagerview/ViewPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,9 @@ class ViewPagerAdapter() : Adapter<ViewPagerViewHolder>() {
}

fun removeAll() {
for (index in 1..childrenViews.size) {
val child = childrenViews[index-1]
if (child.parent?.parent != null) {
(child.parent.parent as ViewGroup).removeView(child.parent as View)
for (child in childrenViews) {
if (child.parent != null) {
(child.parent as ViewGroup).removeView(child)
}
}
val removedChildrenCount = childrenViews.size
Expand Down