New function to correct subject ids #27
Conversation
run_subject_id_correction.py
Outdated
|
|
||
| def all_corrected(): | ||
|
|
||
| record = "2d2wf-j0256" |
There was a problem hiding this comment.
I'd like the test to create the test record.
| return False | ||
| print("All subject ids were added") | ||
| return True | ||
|
|
There was a problem hiding this comment.
Add a test where a record has some subjects that aren't being edited
|
Also add your info to the codemeta.json file, like you did for caltechdata_api |
|
|
||
| metadata = get_metadata( | ||
| record, | ||
| production=False, |
There was a problem hiding this comment.
You're going to need to set this based on the test variable (or change it to `production for consistency)
| metadata = get_metadata( | ||
| record, | ||
| production=False, | ||
| validate=True, |
There was a problem hiding this comment.
You don't need to include anything that's a default.
| authors=False, | ||
| ) | ||
|
|
||
| print(metadata["subjects"]) |
| new_subjects = [] | ||
|
|
||
| for subject_entry in metadata["subjects"]: | ||
| subject_name = subject_entry["subject"].strip().lower() |
There was a problem hiding this comment.
Why are you comparing based on a lowercase version of the subject? We want to compare based on what's in the repository.
| @@ -0,0 +1,189 @@ | |||
| import unittest | |||
| import os, copy, time, requests | |||
| from run_subject_id_correction import all_corrected | |||
There was a problem hiding this comment.
I thought this was going to move into this file?
| authors=False, | ||
| ) | ||
|
|
||
| for subject_idx in range(len(record_metadata["subjects"])): |
There was a problem hiding this comment.
This looks like test code that should be in the tests
| from run_subject_id_correction import all_corrected | ||
| from caltechdata_api import caltechdata_write, get_metadata | ||
|
|
||
| os.environ["RDMTOK"] = "FVyjwsxBvfNXm5NmmfL8fKGI8hhA6puT9pNJO8PAyrLlNYdeMjfjhBVvuhbs" |
There was a problem hiding this comment.
Remove this and delete the token in the test system
Implemented a new function to correct subject ids in caltechdata.