Skip to content

Release r1.1 with 0.1.0-rc.1 version (Fall'25 M3)#15

Merged
Kevsy merged 34 commits intocamaraproject:mainfrom
urvika-v:urvika-v-patch-2
Jul 31, 2025
Merged

Release r1.1 with 0.1.0-rc.1 version (Fall'25 M3)#15
Kevsy merged 34 commits intocamaraproject:mainfrom
urvika-v:urvika-v-patch-2

Conversation

@urvika-v
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M3 release candidate v0.1.0-rc.1

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

None

Changelog input

 release-note
 - Publication of Fall'25 M3 release candidate v0.1.0-rc.1

Additional documentation

This section can be blank.

docs

@jgarciatovar
Copy link

Apart from that small typo in comment above, LGTM.

Kevsy
Kevsy previously approved these changes Jun 26, 2025
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As per API versioning guidelines "For initial public API versions 0.y.z, the MINOR number MUST be included in the URL, e.g. v0.y. "
Kevsy
Kevsy previously approved these changes Jun 26, 2025
Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I fixed the the API version in the URL)

maheshc01
maheshc01 previously approved these changes Jun 27, 2025
@urvika-v urvika-v dismissed stale reviews from maheshc01 and Kevsy via b2652b6 June 30, 2025 10:40
<!-- Pre-releases of this sub project are available in https://github.com/camaraproject/ApplicationEndpointRegistration/releases -->
<!-- The latest public release is available here: https://github.com/camaraproject/ApplicationEndpointRegistration/releases/latest -->
<!-- For changes see [CHANGELOG.md](https://github.com/camaraproject/ApplicationEndpointRegistration/blob/main/CHANGELOG.md) -->
Pre-releases of this sub project are available in https://github.com/camaraproject/ApplicationEndpointRegistration/releases
Copy link
Contributor

@Kevsy Kevsy Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Pre-releases of this sub project are available in https://github.com/camaraproject/ApplicationEndpointRegistration/releases
Pre-releases of this API repository are available in https://github.com/camaraproject/ApplicationEndpointRegistration/releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out because there are no pre-releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should this line be used, with r1.1 there is a release in this repository.

But change it a little bit (template need to be updated):
Pre-releases of this API repository are available in https://github.com/camaraproject/ApplicationEndpointRegistration/releases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should this line be used, with r1.1 there is a release in this repository

Ah yes - I forgot the clarification on the Wiki: "
A pre-release is a GitHub release of an alpha or release-candidate API version. Note: the term release is also often used here but it should be clear from the context."

Thanks, and I'll update the text to state "API repository" as suggested above.

@urvika-v urvika-v requested a review from tanjadegroot July 29, 2025 20:53
Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important change to align on standard API design practice, and a few tweeks and you will be ok to go.

@@ -2,7 +2,7 @@
openapi: 3.0.3
info:
title: Application Endpoints Registration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CAMARA (and industry) recommendation is to have the resource name always as plural.
then the POST and GET operation are on the same endpoint.

Although I agree this is a bit counter intuitive, your above approach is not standard practice for REST APIs (for developers using the API), which is to use plural for the resource name.
I recommend that you group the POST and GET operations under /application-endpoint-lists (in plural)

urvika-v and others added 3 commits July 30, 2025 23:56
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
@urvika-v
Copy link
Contributor Author

@tanjadegroot Thank you for the comments. I have done the changes, could you please review.

@urvika-v urvika-v requested a review from tanjadegroot July 30, 2025 18:42
tanjadegroot
tanjadegroot previously approved these changes Jul 30, 2025
Copy link
Contributor

@tanjadegroot tanjadegroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for all the work, Urvika
It looks great !
/LGTM from Release Management

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes (see suggestions to commit above)

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@urvika-v
Copy link
Contributor Author

Thank you @Kevsy for the comments, I have updated the Test file.

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @urvika-v - all good from codeowner review

@Kevsy
Copy link
Contributor

Kevsy commented Jul 31, 2025

@urvika-v you can proceed with the PR merge, pre-release and wiki update: or if you let me know within the next 30 minutes of this comment I can do it :)

These are the tasks:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@urvika-v urvika-v closed this Jul 31, 2025
@Kevsy Kevsy reopened this Jul 31, 2025
@Kevsy
Copy link
Contributor

Kevsy commented Jul 31, 2025

@urvika-v this reviewed/approved PR was closed without merging, please proceed with the tasks from my comment above (or I can do them, just let me know)

@urvika-v
Copy link
Contributor Author

@Kevsy , I guess I am not code owner. The option to merge is not available for me.

@Kevsy
Copy link
Contributor

Kevsy commented Jul 31, 2025

@Kevsy , I guess I am not code owner. The option to merge is not available for me.

No problem @urvika-v , I'll go ahead. Thanks for making all the changes 👍

@Kevsy Kevsy merged commit e1239a7 into camaraproject:main Jul 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants