Public Release r2.2 (Fall25 M4) for BlockchainPublicAddress APIs#109
Public Release r2.2 (Fall25 M4) for BlockchainPublicAddress APIs#109PedroDiez merged 9 commits intocamaraproject:mainfrom
Conversation
CHANGELOG.md
Outdated
| - **This version contains changes compared to v0.2.0:** | ||
| - Removal of `401 - AUTHENTICATION_REQUIRED` | ||
| - New pattern for `x-correlator` | ||
| - Addition of a new section `# Additional CAMARA error responses` in `info.description` field | ||
| - Addition of `422 - BLOCKCHAIN_PUBLIC_ADDRESS.UNSUPPORTED_ENHANCED_VALIDATION` | ||
| - Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_NONCE` | ||
| - Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_SIGNATURE` | ||
| - Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.BOTH_NONCE_SIGNATURE_REQUIRED` |
There was a problem hiding this comment.
Please can you group these into
Added
Changed
Fixed
Removed
There was a problem hiding this comment.
I prefer removing those Lines 36 - 42 as already mentioned below (so avoiding unnecessary duplication)
Added
- Binding enforcement procedure, including addition of new errors
422 - BLOCKCHAIN_PUBLIC_ADDRESS.UNSUPPORTED_ENHANCED_VALIDATION,400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_NONCE,400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_SIGNATUREand400 - BLOCKCHAIN_PUBLIC_ADDRESS.BOTH_NONCE_SIGNATURE_REQUIREDin Enforcement of BlockChain Public Address Ownership #76, Binding Enforcement - Off-Chain Solution #95 and Enforce Binding Off Chain Solution Editorial Enhancements #97. - New section
# Additional CAMARA error responsesininfo.descriptionfield in Blockchain Public Address RC Tranversal WG Aligment Fall 25 #99.
Changed
- New pattern for
x-correlatorand model aligment with Commonalities in Blockchain Public Address RC Tranversal WG Aligment Fall 25 #99. - Update User Stories adding a new user story for Binding Enforcement and making some wording alignment in Fall 25 Blockchain Public Address User Stories Update #100.
- Update Gherkin feature files, adding a new test for testing invalid x-correlator value in all API endpoints, adding a specific test to check binding enforcement in
bindBlockchainPublicAddressendpoint and making some wording alignments with Commonalities in Fall25 Blockchain Public Address Gherkin Update #101 and APIs aligment with Transversal WGs Public Releases Fall25 #108. - Error schema model alignment with Commonalities in APIs aligment with Transversal WGs Public Releases Fall25 #108.
Fixed
- N/A
Removed
401 - AUTHENTICATION_REQUIREDerror in Blockchain Public Address RC Tranversal WG Aligment Fall 25 #99.
| @@ -58,13 +58,13 @@ info: | |||
| license: | |||
There was a problem hiding this comment.
Line 28: Please change the link to the "Binding Enforcement" image : it currently includes /main/ in the path, which must be replace with /r2.2/
There was a problem hiding this comment.
For blockchain-public-address.yaml:
As well as the inline comments, please can you change the the documentation here (additions in bold just for illustration):
L5: "This API allows the API consumer to generate a one-time nonce for Enhanced Binding validation for Blockchain Public Address associated with a mobile phone number."
L12 "This API allows the API consumer to generate a one-time nonce" etc.
Kevsy
left a comment
There was a problem hiding this comment.
For blockchain-public-address-validation.yaml, please can you add the text shown in bold below in the info.description
L5: This API allows the API consumer to generate a one-time nonce for Enhanced Binding validation for Blockchain Public Address associated with a mobile phone number.
|
Note there is another open approved PR (adding a codeowner). Please can you either:
|
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
ok, i will re-write in order to not miss the main point of the API |
|
Ready again for review @Kevsy, @grgpapadopoulos, @rartych |
There was a problem hiding this comment.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
|
Merging PR and proceeding with release tag generation |
|
Release tag generated: https://github.com/camaraproject/BlockchainPublicAddress/releases/tag/r2.2 |
What type of PR is this?
What this PR does / why we need it:
PR for Public Release r2.2 Generation for BlockChain Public Address APIs
Which issue(s) this PR fixes:
Fixes #79
Fixes #86
Special notes for reviewers:
To review after PR #108 merge
Changelog input
Additional documentation
This section can be blank.