Skip to content

Public Release r2.2 (Fall25 M4) for BlockchainPublicAddress APIs#109

Merged
PedroDiez merged 9 commits intocamaraproject:mainfrom
PedroDiez:r2.2
Sep 11, 2025
Merged

Public Release r2.2 (Fall25 M4) for BlockchainPublicAddress APIs#109
PedroDiez merged 9 commits intocamaraproject:mainfrom
PedroDiez:r2.2

Conversation

@PedroDiez
Copy link
Collaborator

What type of PR is this?

  • documentation
  • subproject management

What this PR does / why we need it:

PR for Public Release r2.2 Generation for BlockChain Public Address APIs

Which issue(s) this PR fixes:

Fixes #79
Fixes #86

Special notes for reviewers:

To review after PR #108 merge

Changelog input

 Public Release r2.2 for Blockchain Public Address APIs

Additional documentation

This section can be blank.

docs

@PedroDiez PedroDiez self-assigned this Aug 19, 2025
@PedroDiez PedroDiez requested a review from a team as a code owner August 19, 2025 13:34
@PedroDiez PedroDiez added the documentation Improvements or additions to documentation label Aug 19, 2025
@PedroDiez PedroDiez added the repository management Indicating issues with the repository or release management process label Aug 19, 2025
@PedroDiez PedroDiez marked this pull request as draft August 19, 2025 13:34
@Kevsy Kevsy changed the title Public Release r2.2 for BlockchainPublicAddress APIs Public Release r2.2 (Fall'25 M4) for BlockchainPublicAddress APIs Aug 21, 2025
@PedroDiez PedroDiez changed the title Public Release r2.2 (Fall'25 M4) for BlockchainPublicAddress APIs Public Release r2.2 (Fall25 M4) for BlockchainPublicAddress APIs Aug 22, 2025
@PedroDiez PedroDiez marked this pull request as ready for review August 26, 2025 13:14
CHANGELOG.md Outdated
Comment on lines +35 to +42
- **This version contains changes compared to v0.2.0:**
- Removal of `401 - AUTHENTICATION_REQUIRED`
- New pattern for `x-correlator`
- Addition of a new section `# Additional CAMARA error responses` in `info.description` field
- Addition of `422 - BLOCKCHAIN_PUBLIC_ADDRESS.UNSUPPORTED_ENHANCED_VALIDATION`
- Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_NONCE`
- Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_SIGNATURE`
- Addition of `400 - BLOCKCHAIN_PUBLIC_ADDRESS.BOTH_NONCE_SIGNATURE_REQUIRED`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you group these into

Added

Changed

Fixed

Removed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer removing those Lines 36 - 42 as already mentioned below (so avoiding unnecessary duplication)

Added

Changed

Fixed

  • N/A

Removed

@@ -58,13 +58,13 @@ info:
license:
Copy link
Contributor

@Kevsy Kevsy Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 28: Please change the link to the "Binding Enforcement" image : it currently includes /main/ in the path, which must be replace with /r2.2/

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For blockchain-public-address.yaml:

As well as the inline comments, please can you change the the documentation here (additions in bold just for illustration):

L5: "This API allows the API consumer to generate a one-time nonce for Enhanced Binding validation for Blockchain Public Address associated with a mobile phone number."

L12 "This API allows the API consumer to generate a one-time nonce" etc.

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For blockchain-public-address-validation.yaml, please can you add the text shown in bold below in the info.description

L5: This API allows the API consumer to generate a one-time nonce for Enhanced Binding validation for Blockchain Public Address associated with a mobile phone number.

@Kevsy
Copy link
Contributor

Kevsy commented Sep 4, 2025

Note there is another open approved PR (adding a codeowner). Please can you either:

  • merge it into main, and then merge main into the Release PR (rebase)
  • or mark the codeowner PR as draft?

Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
PedroDiez and others added 2 commits September 9, 2025 18:22
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@PedroDiez
Copy link
Collaborator Author

For blockchain-public-address.yaml:

As well as the inline comments, please can you change the the documentation here (additions in bold just for illustration):

L5: "This API allows the API consumer to generate a one-time nonce for Enhanced Binding validation for Blockchain Public Address associated with a mobile phone number."

L12 "This API allows the API consumer to generate a one-time nonce" etc.

ok, i will re-write in order to not miss the main point of the API

@PedroDiez
Copy link
Collaborator Author

Ready again for review @Kevsy, @grgpapadopoulos, @rartych

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@PedroDiez
Copy link
Collaborator Author

Merging PR and proceeding with release tag generation

Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez PedroDiez merged commit ff5121c into camaraproject:main Sep 11, 2025
2 checks passed
@PedroDiez
Copy link
Collaborator Author

@PedroDiez
Copy link
Collaborator Author

PedroDiez commented Sep 11, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation repository management Indicating issues with the repository or release management process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope for blockchain-public-address-validation version 0.1.0 Scope for blockchain-public-address version 0.3.0

4 participants