CAMARA_common.yaml - alignment with OWASP and other linting rules#590
Open
rartych wants to merge 6 commits intocamaraproject:mainfrom
Open
CAMARA_common.yaml - alignment with OWASP and other linting rules#590rartych wants to merge 6 commits intocamaraproject:mainfrom
rartych wants to merge 6 commits intocamaraproject:mainfrom
Conversation
rartych
requested review from
PedroDiez,
jlurien,
patrice-conil and
shilpa-padgaonkar
as code owners
2 tasks
tlohmar
reviewed
Mar 3, 2026
Contributor
tlohmar
left a comment
tlohmar
left a comment
There was a problem hiding this comment.
Looks generally good. Is there some recommendations, how to select a length restrictions, e.g. for identifiers like the NAI?
| NetworkAccessIdentifier: | ||
| description: A public identifier addressing a subscription in a mobile network. In 3GPP terminology, it corresponds to the GPSI formatted with the External Identifier ({Local Identifier}@{Domain Identifier}). Unlike the telephone number, the network access identifier is not subjected to portability ruling in force, and is individually managed by each operator. | ||
| type: string | ||
| maxLength: 253 |
Contributor
There was a problem hiding this comment.
Why 253 and not 255?
253 feels a bit short, why not 1024 or 2048?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
CAMARA_common.yaml includes schema definitions that raise linter errors when used in CAMARA API specifications.
New OWASP API linting rules will raise additional erros related to unrestricted string/integer properties.
This PR:
Which issue(s) this PR fixes:
Fixes #584
Does this PR introduce a breaking change?
Restrictions for string/integer properties
Special notes for reviewers:
Changelog input
Additional documentation
https://github.com/camaraproject/Commonalities/blob/main/documentation/Linting-rules.md#5-owasp-api-security-top-10-2023-rules