Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@jlurien which of the open PRs are actually planned for Fall25 still? |
Kevsy
left a comment
There was a problem hiding this comment.
Codeowner fixes required following release management review
As well as my inline suggestions above, please can you make the following changes:
- geofencing-subscriptions.yaml
Please change the URL part /main/ to /r3.2/ in the links in these two lines:
Line 675
Line 727
- All .feature files
Please add this line under# Implementation indicationsin each .feature file:
# * apiRoot: API root of the server URL
That is unfortunately not the solution as the document within the link is deprecated - I opened in Commonalities (camaraproject/Commonalities#531), as this is also within the template. Short-term I recommend to copy the definition from sim-swap-subscription, if @bigludo7 has not a better proposal. |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
|
@Kevsy All your requests fixed - Thanks for the review Regarding the link to obscolete doc I've updated but perhaps let's wait camaraproject/Commonalities#531 outcome. |
|
(This looks good from my release-management and automated review, but I will wait to approve until we know the Commonalities decision, as @bigludo7 says) |
|
Following the Commonalities decision to accept the amended event-subscription-template text, I'm happy to approve 👍 |
There was a problem hiding this comment.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
What type of PR is this?
What this PR does / why we need it:
Applies changes to be merged prior to the creation of the next public release r3.2
Which issue(s) this PR fixes:
Fixes #370
Special notes for reviewers:
All other PRs in the scope for Fall25 must be merged prior to this one, and this one realigned with master