Release r1.2 (Fall'25 M4)#47
Conversation
…ubscription.feature
…ubscription.feature
…ubscription.feature
…sSubscription.feature
…sSubscriptionList.feature
eric-murray
requested review from
a team,
akoshunyadi,
bigludo7 and
sachinvodafone
as code owners
bigludo7
left a comment
bigludo7
left a comment
There was a problem hiding this comment.
Thanks @eric-murray
I did a review and look go for me. I small suggestion in the checklist.
I approve as code owner but to avoid collision with release management approval I will not do the formal git hub approve.
| | 6 | User stories | O | O | O | M | Y | [/documentation/API_documentation/device-roaming-status-User-Story.md](/documentation/API_documentation/device-roaming-status-User-Story.md) | | ||
| | 7 | Basic API test cases & documentation | O | M | M | M | Y | [/code/Test_definitions/device-roaming-status.feature](/code/Test_definitions/device-roaming-status.feature) | | ||
| | 8 | Enhanced API test cases & documentation | O | O | O | M | Y | [/code/Test_definitions/device-roaming-status.feature](/code/Test_definitions/device-roaming-status.feature) | | ||
| | 9 | Test result statement | O | O | O | M | Y | na | |
There was a problem hiding this comment.
I suggest to add a link to issue #46 in the reference information column
…ubscription.feature to device-roaming-status-subscriptions-createDeviceRoamingStatusSubscription.feature
…sSubscription.feature to device-roaming-status-subscriptions-retrieveDeviceRoamingStatusSubscription.feature
…sSubscriptionList.feature to device-roaming-status-subscriptions-retrieveDeviceRoamingStatusSubscriptionList.feature
There was a problem hiding this comment.
On behalf of @camaraproject/release-management_reviewers
device-roaming-status-subscriptions.yaml:
- https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification -> points to a past release. Moreover, this document is deprecated in the latest Commonalities
Descriptions for properties with format date-time are not aligned with latest Commonalities:
- remove "Recommended format is yyyy-MM-dd'T'HH:mm:ss.SSSZ (i.e. which allows 2023-07-03T14:27:08.312+02:00 or 2023-07-03T12:27:08.312Z)",
- and align descriptions in subscriptions with artifacts/camara-cloudevents/event-subscription-template.yaml
line 869
|
With @eric-murray off I've fixed the issues identified by @jlurien. |
| SubscriptionId: | ||
| type: string | ||
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Model](https://github.com/camaraproject/Commonalities/blob/r2.3/documentation/API-design-guidelines.md#122-event-notification). | ||
| description: The unique identifier of the subscription in the scope of the subscription manager. When this information is contained within an event notification, this concept SHALL be referred as `subscriptionId` as per [Commonalities Event Notification Definition](https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Event-Subscription-and-Notification-Guide.md#31-event-notification-definition). |
There was a problem hiding this comment.
@bigludo7 this deprecated link (into r2.3 or main) is affecting multiple subscriptions API, as it is also within the template. I've created camaraproject/Commonalities#531 for the issue which has to be fixed also in Commonalities.
Please change the link here from /main/ to /r3.3/ and propose your updated text within the issue as solution. But maybe it is better to avoid such a link in the template completely to avoid the needed maintenance (as it is in SimSwap).
|
Following @hdamker the subscriptionId attribute description has been fixed to remove deprecated link. We will need your review & approval. Thanks |
|
Please disregard the campusoxide approval, as it is my other GitHub account. Apologies for any confusion caused. |
hdamker
dismissed
jlurien’s stale review
On behalf of ReleaseManagement reviewers: the changes requested by @jlurien are done, the PR is ready for approval.
hdamker
left a comment
hdamker
left a comment
There was a problem hiding this comment.
Thanks @eric-murray @bigludo7
Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)
6 participants
What type of PR is this?
What this PR does / why we need it:
Publication of Fall'25 M4 public release of:
Which issue(s) this PR fixes:
Fixes #40
Special notes for reviewers:
None
Changelog input
Additional documentation
None