Include missing scenario in test plan and fix typos#77
Merged
bigludo7 merged 3 commits intocamaraproject:mainfrom Dec 16, 2025
Conversation
Contributor
albertoramosmonagas
left a comment
There was a problem hiding this comment.
All good, but I would like to add a few comments:
- Units: the tests mix hours (default maxAge 240 hours) with monitoredPeriod described in days. It would be better to standardize or explicitly clarify both units in each assert.
- And I would suggest adding 3 more tests:
@check_device_swap_8_connected_no_swap
/check – Connected without swap (ever):
Then 200 and body {“swapped”: false, “monitoredPeriod”: <value>}.
@retrieve_device_swap_7_connected_no_swap
/retrieve-date – Connected without swap (ever):
Variant A: {“latestDeviceChange”: “<activationDate>”}
Variant B (if policy does not allow date): {“latestDeviceChange”: null, “monitoredPeriod”: <value>}.
@check_device_swap_9_first_installation_is_swap
/check – First installation within period:
Then 200 and body {“swapped”: true, “monitoredPeriod”: <value>}.
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Contributor
Author
thanks @albertoramosmonagas for the comments, I have updated accordingly |
albertoramosmonagas
approved these changes
Oct 31, 2025
bigludo7
approved these changes
Oct 31, 2025
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Thanks @fernandopradocabrillo and @albertoramosmonagas for additional cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Include:
Which issue(s) this PR fixes:
Fixes #73