Skip to content

Release 1.3 (M4 Fall25)#98

Merged
FabrizioMoggio merged 47 commits intocamaraproject:mainfrom
FabrizioMoggio:v0.1.0-public-2
Sep 14, 2025
Merged

Release 1.3 (M4 Fall25)#98
FabrizioMoggio merged 47 commits intocamaraproject:mainfrom
FabrizioMoggio:v0.1.0-public-2

Conversation

@FabrizioMoggio
Copy link
Contributor

@FabrizioMoggio FabrizioMoggio commented Aug 19, 2025

What type of PR is this?

  • documentation

What this PR does / why we need it:

This is the M4 PR for the public version of the EFN API, for the Fall25 Meta Release. The PR changes the API version from WIP to 0.1.0 ad provides the updated README.md and CHANGELOG.md files.

Which issue(s) this PR fixes:

#100

@FabrizioMoggio FabrizioMoggio requested a review from a team as a code owner August 19, 2025 14:39
@hdamker hdamker changed the title M4: V0.1.0 public Release 1.3 (M4 Fall25) Aug 30, 2025
@hdamker
Copy link
Contributor

hdamker commented Aug 30, 2025

@FabrizioMoggio I've done first round of review and provide here the results. Please do all needed changes which are not directly related to the release within separate PRs and update the release PR branch afterwards from main.

API Name - critical:

  • I understand that you changed the API name during the review of rc.1 by @tanjadegroot from energy-footprint-notification to energy-footprint
  • But the change has been done only partly:
    • file names of the API and test definitions should use the API name, they are still energy-footprint-notification
    • the CHANGELOG.md still lists energy-footprint-notification
    • the CloudEventType uses still energy-footprint-notification as api-name
    • the test definition is still using the previous server URL (and is therefore inconsistent with the YAML)
  • My recommendation would be to revert back to energy-footprint-notification as API name. Why:
    • Asynchronous, callback-based API; “notification” clarifies the delivery model
    • Avoids ambiguity of “energy-footprint” (which suggests synchronous query)
    • Already consistent with repository name, file names, CloudEvent types and test definitions -> less alignments needed across all files
  • Alignments to make:
    • Servers base path: {apiRoot}/energy-footprint-notification/v0.1
    • OAuth scopes: energy-footprint-notification:calculate-energy-consumption, energy-footprint-notification:calculate-carbon-footprint
    • Title

Callbacks/Events

Info.description

  • In info.description, remove outdated endpoint bullets (e.g., /overall-energy-consumption) that do not match actual paths (/calculate-energy-consumption, /calculate-carbon-footprint).

@hdamker
Copy link
Contributor

hdamker commented Aug 30, 2025

Note: the request for changes is mainly related to the issues in #98 (comment).
Please update the PR from main when the needed alignments are done and mark the PR again as ready for review.

@hdamker hdamker marked this pull request as draft August 30, 2025 17:37
@FabrizioMoggio
Copy link
Contributor Author

If you plan to run the PR with non-release changes first, you might want to consider to set the PR here to draft until done.

I have already done the WIP PR (#103), now this PR should be ok and ready to be reviewed/approved

@hdamker
Copy link
Contributor

hdamker commented Sep 2, 2025

I have already done the WIP PR (#103), now this PR should be ok and ready to be reviewed/approved

@FabrizioMoggio yes, much nicer now. Even our release validation workflow is happy. Will continue with the review.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FabrizioMoggio looks already quite good, some smaller comments on the CHANGELOG.md

@hdamker
Copy link
Contributor

hdamker commented Sep 2, 2025

Beyond the above comments there is a fix of the ErrorInfo schema in CAMARA_common.yaml which will come in a patch release of Commonalities. You can apply it already now as the fix is compliant to r3.3 of the API Design Guide, but it is neither critical nor mandatory for you now:

If you apply it now then please again in a separate PR against main.

@FabrizioMoggio
Copy link
Contributor Author

Beyond the above comments there is a fix of the ErrorInfo schema in CAMARA_common.yaml which will come in a patch release of Commonalities. You can apply it already now as the fix is compliant to r3.3 of the API Design Guide, but it is neither critical nor mandatory for you now:

If you apply it now then please again in a separate PR against main.

If not mandatory, at this point, I prefer not to engage the supporting partners on another round of wip-approval-merge-align- etc. This would be easy for this API but for TI API and CFS API I need more coordination with the other members. For this reason I'm planning to keep this issue open for all my APIs and fix it for the next meta release. The time is a great constraint at this point.

@hdamker
Copy link
Contributor

hdamker commented Sep 3, 2025

If not mandatory, at this point, I prefer not to engage the supporting partners on another round of wip-approval-merge-align- etc. This would be easy for this API but for TI API and CFS API I need more coordination with the other members. For this reason I'm planning to keep this issue open for all my APIs and fix it for the next meta release. The time is a great constraint at this point.

@FabrizioMoggio That's fine and your decision. But just seen that in TrafficInfluence you need anyway to clean-up your legacy ErrResponse schema(s).

@FabrizioMoggio
Copy link
Contributor Author

If not mandatory, at this point, I prefer not to engage the supporting partners on another round of wip-approval-merge-align- etc. This would be easy for this API but for TI API and CFS API I need more coordination with the other members. For this reason I'm planning to keep this issue open for all my APIs and fix it for the next meta release. The time is a great constraint at this point.

@FabrizioMoggio That's fine and your decision. But just seen that in TrafficInfluence you need anyway to clean-up your legacy ErrResponse schema(s).

If I have other issues to fix I will also include it.

@FabrizioMoggio
Copy link
Contributor Author

ErroInfo fixed

FabrizioMoggio and others added 4 commits September 3, 2025 14:52
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@hdamker
Copy link
Contributor

hdamker commented Sep 4, 2025

ErroInfo fixed

Unfortunately not ... you changed only the order in "required", but not the actual schema.

@FabrizioMoggio FabrizioMoggio marked this pull request as draft September 8, 2025 06:28
@FabrizioMoggio FabrizioMoggio marked this pull request as ready for review September 8, 2025 06:32
@FabrizioMoggio
Copy link
Contributor Author

Everything has been addressed

@hdamker
Copy link
Contributor

hdamker commented Sep 13, 2025

Everything has been addressed

Great! I will approve now for release management. You might want to consider to remove the placeholder README.md files in the directories. Happy to approve again, if you dismiss my approval with that.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@FabrizioMoggio FabrizioMoggio merged commit 00321e2 into camaraproject:main Sep 14, 2025
2 checks passed
@FabrizioMoggio
Copy link
Contributor Author

Everything has been addressed

Great! I will approve now for release management. You might want to consider to remove the placeholder README.md files in the directories. Happy to approve again, if you dismiss my approval with that.

Dear Herbert, I'm sorry I didn't notice this request of yours before creating the release.

@hdamker
Copy link
Contributor

hdamker commented Sep 16, 2025

Dear Herbert, I'm sorry I didn't notice this request of yours before creating the release.

No worries, the files are doing no harm. Let's delete them together with the reset to wip.

@FabrizioMoggio
Copy link
Contributor Author

Dear Herbert, I'm sorry I didn't notice this request of yours before creating the release.

No worries, the files are doing no harm. Let's delete them together with the reset to wip.

I'm sorry I'm not sure how to proceed because I'm not sure to have got you right :-). The release has been merged and the release tag created. I will delete the file when a new wip will be created. For the next release I mean. Is my understanding right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants