Release 1.3 (M4 Fall25)#98
Conversation
merge from main wip
|
@FabrizioMoggio I've done first round of review and provide here the results. Please do all needed changes which are not directly related to the release within separate PRs and update the release PR branch afterwards from main. API Name - critical:
Callbacks/Events
Info.description
|
|
Note: the request for changes is mainly related to the issues in #98 (comment). |
… to energy-footprint-calculateCarbonFootprint.feature camaraproject#98 (comment)
…re to energy-footprint-calculateEnergyConsumption.feature camaraproject#98 (comment)
renamed from "EFN" to "EF"
renamed from "EFN" to "EF"
…st.md to energy-footprint-API-Readiness-Checklist.md renamed from "EFN" to "EF"
removed "-notification"
removed "-notification"
I have already done the WIP PR (#103), now this PR should be ok and ready to be reviewed/approved |
@FabrizioMoggio yes, much nicer now. Even our release validation workflow is happy. Will continue with the review. |
hdamker
left a comment
There was a problem hiding this comment.
@FabrizioMoggio looks already quite good, some smaller comments on the CHANGELOG.md
|
Beyond the above comments there is a fix of the ErrorInfo schema in CAMARA_common.yaml which will come in a patch release of Commonalities. You can apply it already now as the fix is compliant to r3.3 of the API Design Guide, but it is neither critical nor mandatory for you now: If you apply it now then please again in a separate PR against main. |
If not mandatory, at this point, I prefer not to engage the supporting partners on another round of wip-approval-merge-align- etc. This would be easy for this API but for TI API and CFS API I need more coordination with the other members. For this reason I'm planning to keep this issue open for all my APIs and fix it for the next meta release. The time is a great constraint at this point. |
@FabrizioMoggio That's fine and your decision. But just seen that in TrafficInfluence you need anyway to clean-up your legacy ErrResponse schema(s). |
If I have other issues to fix I will also include it. |
Alignment with main
|
ErroInfo fixed |
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Unfortunately not ... you changed only the order in "required", but not the actual schema. |
alignment with main
|
Everything has been addressed |
Great! I will approve now for release management. You might want to consider to remove the placeholder README.md files in the directories. Happy to approve again, if you dismiss my approval with that. |
There was a problem hiding this comment.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
Dear Herbert, I'm sorry I didn't notice this request of yours before creating the release. |
No worries, the files are doing no harm. Let's delete them together with the reset to |
I'm sorry I'm not sure how to proceed because I'm not sure to have got you right :-). The release has been merged and the release tag created. I will delete the file when a new wip will be created. For the next release I mean. Is my understanding right? |
What type of PR is this?
What this PR does / why we need it:
This is the M4 PR for the public version of the EFN API, for the Fall25 Meta Release. The PR changes the API version from WIP to 0.1.0 ad provides the updated README.md and CHANGELOG.md files.
Which issue(s) this PR fixes:
#100