Skip to content

Update MAINTAINERS.MD#27

Merged
hdamker merged 1 commit intocamaraproject:mainfrom
FabrizioMoggio:FirstRepoSetup
Sep 24, 2025
Merged

Update MAINTAINERS.MD#27
hdamker merged 1 commit intocamaraproject:mainfrom
FabrizioMoggio:FirstRepoSetup

Conversation

@FabrizioMoggio
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation
  • repository management

What this PR does / why we need it:

Adds codeowners

Which issue(s) this PR fixes:

#26

@FabrizioMoggio FabrizioMoggio requested a review from a team as a code owner September 24, 2025 09:56
@FabrizioMoggio FabrizioMoggio mentioned this pull request Sep 24, 2025
@FabrizioMoggio
Copy link
Contributor Author

@camaraproject/admins why is requested an approval from you?

Copy link

@eharrison24 eharrison24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@eharrison24
Copy link

eharrison24 commented Sep 24, 2025

@FabrizioMoggio - the camaraadmins are listed as reviewers for just about all repo changes - just as an extra buffer.

@hdamker
Copy link
Contributor

hdamker commented Sep 24, 2025

@FabrizioMoggio - the camaraadmins are listed as reviewers for just about all repo changes - just as an extra buffer.

@eharrison24 The purpose is to keep the respective GitHub team in sync. Please approve changes to CODEOWNERS and MAINTAINERS.md files only after you have updated the team, in this case @camaraproject/iot-network-optimization_maintainers, and potential new member to the CAMARA organization have accepted the invitation.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have invited @varanto and @FabrizioMoggio to @camaraproject/iot-network-optimization_maintainers.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both @varanto and @FabrizioMoggio are already members of the CAMARA organization and with that the team is up-to-date. Thanks for taking this role!

@hdamker hdamker merged commit 1d6241c into camaraproject:main Sep 24, 2025
2 checks passed
@hdamker
Copy link
Contributor

hdamker commented Sep 24, 2025

@camaraproject/admins why is requested an approval from you?

@FabrizioMoggio That's because of these lines in the CODEOWNERS file:

# Owners of the CODEOWNER and Maintainer.md files are the admins of CAMARA (to allow them to keep the teams within the CAMARA organization in sync in case of changes)
/CODEOWNERS @camaraproject/admins
/MAINTAINERS.MD @camaraproject/admins

@eharrison24
Copy link

Looks good, and makes sense. It seemed that both Fabrizio and Antonio were already a part of the group. Nonetheless, makes sense.

@hdamker
Copy link
Contributor

hdamker commented Sep 25, 2025

Looks good, and makes sense. It seemed that both Fabrizio and Antonio were already a part of the group. Nonetheless, makes sense.

@eharrison24 Both were members of the CAMARA organization, but to @camaraproject/iot-network-optimization_maintainers I added them only yesterday before I approved and merged the PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants