Conversation
|
@camaraproject/admins why is requested an approval from you? |
|
@FabrizioMoggio - the camaraadmins are listed as reviewers for just about all repo changes - just as an extra buffer. |
@eharrison24 The purpose is to keep the respective GitHub team in sync. Please approve changes to CODEOWNERS and MAINTAINERS.md files only after you have updated the team, in this case @camaraproject/iot-network-optimization_maintainers, and potential new member to the CAMARA organization have accepted the invitation. |
There was a problem hiding this comment.
Have invited @varanto and @FabrizioMoggio to @camaraproject/iot-network-optimization_maintainers.
hdamker
left a comment
There was a problem hiding this comment.
Both @varanto and @FabrizioMoggio are already members of the CAMARA organization and with that the team is up-to-date. Thanks for taking this role!
@FabrizioMoggio That's because of these lines in the CODEOWNERS file: |
|
Looks good, and makes sense. It seemed that both Fabrizio and Antonio were already a part of the group. Nonetheless, makes sense. |
@eharrison24 Both were members of the CAMARA organization, but to @camaraproject/iot-network-optimization_maintainers I added them only yesterday before I approved and merged the PR: |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds codeowners
Which issue(s) this PR fixes:
#26