Skip to content

Prepare r2.1#26

Merged
fernandopradocabrillo merged 11 commits intocamaraproject:mainfrom
fernandopradocabrillo:prepare-r2.1
Jul 30, 2025
Merged

Prepare r2.1#26
fernandopradocabrillo merged 11 commits intocamaraproject:mainfrom
fernandopradocabrillo:prepare-r2.1

Conversation

@fernandopradocabrillo
Copy link
Contributor

@fernandopradocabrillo fernandopradocabrillo commented Jun 27, 2025

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Preparations for first pre-release of Location Insights for Fall25

Special notes for reviewers:

@chinaunicomyangfan would also like to include the DeviceVisitLocation API as part of this meta-release. The code for the proposal is in #22. Once preparations for Fall25 are applied in that PR, it can be merged and the information in changelog and readme can be updated in this PR.

cc: @FabrizioMoggio

@hdamker hdamker marked this pull request as draft June 29, 2025 11:08
@hdamker
Copy link
Contributor

hdamker commented Jun 29, 2025

@fernandopradocabrillo I converted the PR to draft as there is no release tracker (which I need to create the release review issue) for the Fall25 release, neither for most-frequent-location nor for device-visit-location.

Please see also #28 ... decide about the scope for the Fall25 meta-release (there is no scope issue to check).

@hdamker
Copy link
Contributor

hdamker commented Jul 14, 2025

@fernandopradocabrillo I had already updated README.md as part of the renaming, so would be good if you rebase and resolve the merge conflicts.

@fernandopradocabrillo
Copy link
Contributor Author

@hdamker Fixed, I left the commit prepared on friday but didn't pushed it and didn't see your commit. It should be good now. With the release tracker that you created and the Scope Issue updated I think we can convert this PR from DRAFT to definitive_final_final_ready_to_review

@hdamker
Copy link
Contributor

hdamker commented Jul 14, 2025

definitive_final_final_ready_to_review

feel free to push the button "Ready for review" :-)

@fernandopradocabrillo fernandopradocabrillo marked this pull request as ready for review July 15, 2025 09:09
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@Kevsy
Copy link
Contributor

Kevsy commented Jul 18, 2025

Hi @fernandopradocabrillo although the IDENTIFIER_MISMATCH is removed, there is still some description related to it which should also be removed:

- Inconsistency between device identifiers not pointing to the same device ("code": "DEVICE_IDENTIFIERS_MISMATCH","message": "Provided device identifiers are not consistent.").

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggested changes above in comments

@jlurien
Copy link

jlurien commented Jul 21, 2025

Hi @Kevsy, @fernandopradocabrillo is on vacation this week, so he will take a look to your comments next week.

@Kevsy
Copy link
Contributor

Kevsy commented Jul 24, 2025

Hi @FabrizioMoggio @chinaunicomyangfan - please can you review the comments above in Fernando's absence? The M3 deadline is approaching fast (27th)

@Kevsy
Copy link
Contributor

Kevsy commented Jul 28, 2025

HI @fernandopradocabrillo - please can I ask you to address the comments/suggestions above, as we are now past the M3 deadline? Many thanks for your help :)

@fernandopradocabrillo
Copy link
Contributor Author

HI @fernandopradocabrillo - please can I ask you to address the comments/suggestions above, as we are now past the M3 deadline? Many thanks for your help :)

Hi @Kevsy! Thanks for your comments, I'm on it 😄

@fernandopradocabrillo
Copy link
Contributor Author

Hi @Kevsy, all done! you can review again whenever you can. Thanks!!

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved on behalf of release management 👍

Please can the codeowners perform the next steps:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@fernandopradocabrillo
Copy link
Contributor Author

@FabrizioMoggio please, we need tha approval of another codeowner to be able to merge the PR. Thanks!!

@hdamker
Copy link
Contributor

hdamker commented Jul 29, 2025

@FabrizioMoggio @chinaunicomyangfan We would like to merge this PR today and create the release. Please let us know if it would be ok even without your review. Preferred would be your review and or approval until 15:00 UTC / 17:00 CEST.

Copy link

@chinaunicomyangfan chinaunicomyangfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo fernandopradocabrillo merged commit 0ee9158 into camaraproject:main Jul 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants