Skip to content

Fix feature files for compliance with centralised linting rules#67

Merged
Masa8106 merged 1 commit intocamaraproject:mainfrom
ToshiWakayama-KDDI:toshi-fix-feature-files-linting-errors
Aug 26, 2025
Merged

Fix feature files for compliance with centralised linting rules#67
Masa8106 merged 1 commit intocamaraproject:mainfrom
ToshiWakayama-KDDI:toshi-fix-feature-files-linting-errors

Conversation

@ToshiWakayama-KDDI
Copy link
Contributor

What type of PR is this?

  • correction
  • tests

What this PR does / why we need it:

Some changes are required to the feature files for compliance with centralised linting rules. Mostly indentation changes and removal of spare spaces.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Needs to be merged before PR #66

Changelog input

 release-note
- Fix feature files for compliance with centralised linting rules

Additional documentation

None

@eric-murray
Copy link
Contributor

Hi @ToshiWakayama-KDDI

I think the proposed changes will be compliant with the new linter rules but, to be sure, I'd suggest that you merge your branch ToshiWakayama-KDDI:toshi-fix-feature-files-linting-errors into the new admin branch for this repository camara-admin/centralize-linting-workflows-1755695497516. You can do that without any other codeowner approvals.

Doing that will re-run the centralised linter rules and, if all is good, then it is known that no further changes are required to this PR to achieve linting rule compliance.

@eric-murray
Copy link
Contributor

Actually, I realised I could do that merge myself. All checks pass, so the two PRs can be merged.

@ToshiWakayama-KDDI
Copy link
Contributor Author

Hi @eric-murray ,

Thank you so much. Actually I have been thinking of how I could do it...

Best regards,
Toshi

Copy link
Contributor

@Masa8106 Masa8106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me try to merge this PR.

@Masa8106 Masa8106 merged commit 6ba2d73 into camaraproject:main Aug 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants