Skip to content

Add "C02.02_phone_number_not_found" test scenario#84

Merged
Masa8106 merged 1 commit intocamaraproject:mainfrom
Masa8106:Masa8106-patch-AddTestC0202
Dec 16, 2025
Merged

Add "C02.02_phone_number_not_found" test scenario#84
Masa8106 merged 1 commit intocamaraproject:mainfrom
Masa8106:Masa8106-patch-AddTestC0202

Conversation

@Masa8106
Copy link
Contributor

@Masa8106 Masa8106 commented Nov 24, 2025

What type of PR is this?

  • correction
  • tests

What this PR does / why we need it:

This PR is to add "C02.02_phone_number_not_found" test scenario

Which issue(s) this PR fixes:

Fixes #83

Special notes for reviewers:

My proposal is entirely aligned with the commonalities guideline, and it has a slightly different wording from wording which was proposed in PR#60 previously.

Changelog input

 release-note
- Add "C02.02_phone_number_not_found" test scenario

Additional documentation

None

Copy link
Contributor

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @Masa8106!

@Masa8106
Copy link
Contributor Author

Masa8106 commented Dec 8, 2025

Hi, @eric-murray and @grgpapadopoulos , may I ask you to review this PR?

@grgpapadopoulos
Copy link

Hello @Masa8106,
does it make sense to you to add in the end of the msg:
"...but does not identify a valid phone number known to the operator"

@Masa8106
Copy link
Contributor Author

Hi @grgpapadopoulos ,
Thank you for your suggestion. I think so far it is preferable to adhere the commonalities guidelines, which is to keep the msg as it is, as much as possible. What do you think?

@Masa8106 Masa8106 closed this Dec 15, 2025
@Masa8106 Masa8106 reopened this Dec 16, 2025
@Masa8106
Copy link
Contributor Author

@grgpapadopoulos, thank you for your review quickly and your approval.
Please let me merge this PR. Thank you.

@Masa8106 Masa8106 merged commit 8cbf94f into camaraproject:main Dec 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing "C02.02_phone_number_not_found" test scenario

3 participants